Description of the issue:
How can this issue be reproduced?
Highlight a phone number.
Right click for the context menu.
Choose “Call from [Google] Phone”.
Error message appears: Something went wrong. Try again later.
Expected result:
Brave Version( check About Brave):
Additional Information:
Instead of spamming to ‘bump’ your post, maybe it is better if you research.
First, Who says it should work? and why should it work only because it works in Google (company that develops Chromium and Android, so it is kind of obvious they do features that will favor their ecosystem)
Maybe it is time to be better than some people who are still commenting on github saying ‘it doesn’t work’ when it clearly was disabled but probably they missed the right click one, or Chromium pushed a new update that changed things.
A simple search in Github (because Brave browser is fully open source) would take you to this PR:
brave:master ← brave:disable_sync_phone_call
opened 09:15PM - 06 Apr 21 UTC
Resolves https://github.com/brave/brave-browser/issues/14601, https://github.com… /brave/brave-browser/issues/11526
Share call Chromium feature uses sync to get devices list and uses Google Cloud Messaging to push the call to the Android device. Therefore it is not supported by Brave browser.
The proper way would be to use gn variable `enable_click_to_call`, but setting it to false gives compile errors:
```
../../chrome/browser/sharing/click_to_call/phone_number_regex.cc:43:37: error: use of undeclared identifier 'kClickToCallUI'
if (!base::FeatureList::IsEnabled(kClickToCallUI))
../../chrome/browser/sharing/click_to_call/click_to_call_utils.cc:40:58: error: no member named 'kClickToCallEnabled' in namespace 'prefs'
if (profile && !profile->GetPrefs()->GetBoolean(prefs::kClickToCallEnabled))
~~~~~~~^
../../chrome/browser/sharing/click_to_call/click_to_call_utils.cc:45:58: error: use of undeclared identifier 'kClickToCallUI'
return sharing_service && base::FeatureList::IsEnabled(kClickToCallUI);
^
../../brave/chromium_src/chrome/browser/ui/views/location_bar/../../../../../../../chrome/browser/ui/views/location_bar/location_bar_view.cc:266:38: error: use of undeclared identifier 'kClickToCallUI'
if (base::FeatureList::IsEnabled(kClickToCallUI))
```
By this reason override of `ShouldOfferClickToCallForURL` is used.
## Submitter Checklist:
- [x] I confirm that no security/privacy review [is needed](https://github.com/brave/handbook/blob/master/development/security.md#when-is-a-security-review-needed), or that I have [requested](https://github.com/brave/security/issues/new/choose) one
- [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [ ] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [x] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [ ] Checked the PR locally: `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests`, `npm run lint`, `npm run gn_check`, `npm run tslint`// tested lint only
- [ ] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [ ] A security review [is not needed](https://github.com/brave/handbook/blob/master/development/security.md#when-is-a-security-review-needed), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
1. Put the desktop into the same sync chain with an Android device
2. Open the website which contains `tel:` link, like https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_link_phoneto
3. Click the link with phone number
4. Expected: there is no dialog which choose the device to call from like
Well, I don’t know how a title like that can’t be clear.
You could also have reached this issue:
opened 03:18PM - 31 Aug 20 UTC
closed 02:21PM - 12 Apr 21 UTC
bug
good first issue
feature/sync
QA Pass-Win64
QA Pass-macOS
QA Pass-Linux
priority/P3
QA/Yes
release-notes/exclude
OS/Android
QA Pass - Android ARM
QA Pass - Android Tab
OS/Desktop
QA/Test-All-Platforms
## Description
Brave offers to send phone numbers to a linked mobile device, b… ut fails.
## Steps to Reproduce
1. Place your desktop device and mobile device on the same Sync chain
2. Configure Sync to share _addresses, phone numbers, and more_ in brave://sync/
3. Click a `tel:` link to invoke address-bar prompt
4. Request that the call be made from your mobile device
## Actual result:
Call is not made.
"Couldn't share number. Something went wrong. Try later."
## Expected result:
Call is made from mobile device; or user is prompted on mobile to make the call.
## Reproduces how often:
Always.
## Desktop Brave version:
1.13.82
## Android Device details (my linked mobile device):
## Version/Channel Information:
- Can you reproduce this issue with the current release? Yes
- Can you reproduce this issue with the beta channel? TBD
- Can you reproduce this issue with the nightly channel? TBD
## Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields? TBD
- Does the issue resolve itself when disabling Brave Rewards? TBD
- Is the issue reproducible on the latest version of Chrome? N/A
## Miscellaneous Information:
Desktop is currently set to Sync: _Bookmarks, History, Open Tabs,_ and _Addresses, Phone Numbers, and more_.
Android is currently set to Sync: _Bookmarks, History,_ and _Open Tabs_ (No option presented for _Addresses, Phone Numbers, and more_ on Android.
and see how the test and PRs are to show how it is was never meant to work, and the goal was always to disable it.
anon57438784:
Instead of spamming to ‘bump’ your post, maybe it is better if you research.
[…]
A simple search in Github (because Brave browser is fully open source) would take you to this PR
Why should I search through GitHub or do research if there is an official Brave forum?
Okay, they disabled the feature - fine. But why don’t they remove it from the UI or display a proper error message, letting the user know that this feature is not available in Brave?
If there are so many users commenting on the GitHub forum, it indicates that the UX is not properly designed.
rodrige
January 19, 2023, 11:45am
6
Because before asking someone to do the work for you, you should do the work yourself.
According to the FAQs of this forum:
Brave Community is a place for users to get help and report issues with Brave
And that’s what I did.
I never asked nobody to “do work for me”. I never asked someone to point me out to the GitHub threads or to give me instructions on “how to do research yourself”. I reported an issue as intended by this forum.
system
February 18, 2023, 11:59am
8
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.