Ok I was wondering why is Brave The Only browse that i test that turns every website into light mode? like I can go on Firefox, Chrome, Edge etc. and I don’t have this issue but Brave And I’m not talking about an extension and I have test this on websites that has dark mode available so hope some can explain why this is.
Windows 10
1 Like
It’s due to the recent strict fingerprinting changes.
opened 07:18PM - 13 Apr 21 UTC
closed 04:47PM - 01 Jun 21 UTC
privacy
QA Pass-Win64
QA Pass-macOS
QA Pass-Linux
feature/shields/fingerprint
QA/Yes
release-notes/include
OS/Android
QA Pass - Android ARM
QA Pass - Android Tab
privacy-pod
OS/Desktop
QA/Test-All-Platforms
New CSS features allow sites to determine if your OS or environment is configure… d for Dark Mode (or similar names). See [CSS Media Queries Level 5](https://drafts.csswg.org/mediaqueries-5/#descdef-media-prefers-color-scheme)
We should disable this detection for users wanting the highest level of fingerprinting protection ("strict").
**default protections**: no changes
**max protections**: always report that the user prefers "light"
@shivan introduced a flag that allows users to opt out of the dark mode blocking while using strict fingerprinting protection. The flag is currently available in Nightly, so until it is uplifted into the stable channel, you can set Standard fingerprinting protection on a per-site or global level so you can continue using a dark theme. The third option would be to use Brave Nightly if you find the dark theme a must while using strict fingerprinting protection.
brave:master ← brave:fingerprinting/dark-mode-block-feature-flag
opened 06:22AM - 12 Aug 21 UTC
Resolves https://github.com/brave/brave-browser/issues/17139.
I'm working on … a fix to disable Brave Shields when there's a navigation error which will address general issues of that class (plus remove confusing UX), but in the meantime, adding an opt-out for folks who don't want fingerprinting strict to mess with their dark mode.
## Submitter Checklist:
- [x] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one
- [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [x] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [x] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [x] Checked the PR locally: `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests`, `npm run lint`, `npm run gn_check`, `npm run tslint`
- [ ] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
system
September 17, 2021, 7:09am
3
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.