Still an issue 27th May 2024.
1 Like
Still an issue for me on the 29/05/2024 +12GMT
Brave v1.66.115 - FAILED
Chrome v125.0.6422.113 - Works
Edge v 125.0.2535.67 - Works
Still broken on 2/6/2024 on Brave 1.66.118.
Still working on literally everything else.
Just went to try Sketchup for the first time and ran into this issue. I will chime in here as I haven’t seen it explicitly stated by anyone else.
I have turned off the privacy shields for the site, as well as going into the site settings to specifically allow popups but that does not fix the issue for Brave.
App works for me in Chrome, and Edge. Haven’t tested any other browsers.
13th June still not working. Had to switch to Safari!
Hi everyone,
Still broken June 17 2024 on Brave 1.67.116 Chromium 125.0.6478.71
Any plans for a fix in the near future?
me as well. on BigLinux, with Brave ver 1.67.123
[quote=“Monologue9644, post:6, topic:539220, full:true”]
I can confirm this happens with Debian 12 on Lenovo IdeaPad Flex 5 , it works on Chromium just not on Brave Browser
I give up. Site access being completely broken for months with complete radio silence is a deal breaker for me. Hello Vivaldi & goodbye Brave.
This should be fixed in the latest Nightly and will be upstreamed soon into the next 1.67 release.
Apologies for the delay
brave:master ← brave:bugfix/webgl/get-attached-shaders-patch
opened 09:56PM - 01 Jul 24 UTC
Resolves https://github.com/brave/brave-browser/issues/37044
In a [recent Chr… omium rebase](https://github.com/brave/brave-core/commit/19b9a04a06016dd1bbf0af824933a658bb13f20c#diff-d2b2184840d764ae72b93a75e[…]a6013f622435fde429595805b9d9R25), we accidentally moved the `BRAVE_WEBGL_RENDERING_CONTEXT_BASE_NULLOPT` macro (defined in [webgl_rendering_context_base](https://github.com/brave/brave-core/blob/master/chromium_src/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc#L35)) to be right after the single-statement if-block which meant that the return statement in [WebGLRenderingContextBase::getAttachedShaders](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc;drc=ec7ff1772b427041ac09644631f39d7cfbf258e4;bpv=1;bpt=1;l=3236?gsn=getAttachedShaders&gs=KYTHE%3A%2F%2Fkythe%3A%2F%2Fchromium.googlesource.com%2Fcodesearch%2Fchromium%2Fsrc%2F%2Fmain%3Flang%3Dc%252B%252B%3Fpath%3Dthird_party%2Fblink%2Frenderer%2Fmodules%2Fwebgl%2Fwebgl_rendering_context_base.cc%23ka2Zp79hO3fFS5AaFI-GvuRLxqkc9ogIIC_3sQzFyeA) always got hit and always returned early. This effectively meant that WebGL `getAttachedShaders()` method always returned `null`.
<!-- CI-related labels that can be applied to this PR:
* CI/run-audit-deps (1) - check for known npm/cargo vulnerabilities (audit_deps)
* CI/run-network-audit (1) - run network-audit
* CI/run-upstream-tests - run Chromium unit and browser tests on Linux and Windows (otherwise only on Linux)
* CI/run-linux-arm64, CI/run-macos-x64, CI/run-windows-arm64, CI/run-windows-x86 - run builds that would otherwise be skipped
* CI/skip - do not run CI builds (except noplatform)
* CI/skip-linux-x64, CI/skip-android, CI/skip-macos-arm64, CI/skip-ios, CI/skip-windows-x64 - skip CI builds for specific platforms
* CI/skip-upstream-tests - do not run Chromium unit, or browser tests (otherwise only on Linux)
* CI/skip-all-linters - do not run presubmit and lint checks
* CI/storybook-url (1) - deploy storybook and provide a unique URL for each build
(1) applied automatically when some files are changed (see: https://github.com/brave/brave-core/blob/master/.github/labeler.yml)
-->
## Submitter Checklist:
- [x] I confirm that no [security/privacy review is needed](https://github.com/brave/brave-browser/wiki/Security-reviews) and no other type of reviews are needed, or that I have [requested](https://github.com/brave/reviews/issues/new/choose) them
- [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [x] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [x] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [x] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [x] Checked the PR locally:
* `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests` [wiki](https://github.com/brave/brave-browser/wiki/Tests)
* `npm run presubmit` [wiki](https://github.com/brave/brave-browser/wiki/Presubmit-checks), `npm run gn_check`, `npm run tslint`
- [x] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
Go to https://shivankaul.com/brave/webgl/get_attached_shaders.html
You should see: `Attached shaders: [object WebGLShader]` printed out on the page.
2 Likes
Finally! It works now. Only took a couple of few
system
September 15, 2024, 8:15pm
34
This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.
