Session is not restored correctly if URL have spaces

289wk · February 4, 2022, 6:01am

Trader_One,

Brave has difficulty with opening some URL addresses - particularly those that have spaces - on occasion.

A URL address for a PDF file can be trouble, when that address has one or more spaces.

An example in general:

github.com/brave/browser-laptop

URL Parsing fails for query string and file name with space

opened 05:41AM - 23 Apr 18 UTC

closed 06:51AM - 18 Jun 18 UTC

AlexWang-16

QA/test-plan-specified feature/search release-notes/include

## Test plan See https://github.com/brave/browser-laptop/pull/13898 ## Origi…nal issue description ### Description • Brave does not parse URL correctly when a space is in the query string. It performs a google search on the URL instead of the topic indicated by the query string • Brave does not parse absolute paths with a space in file name correctly ### Steps to Reproduce Issue 1: Brave does not parse space in query string as valid URL 1. Go to address bar 2. Enter "Https://www.google.com/search?q=dog cat" 3. Press enter Issue 2: Brave does not parse absolute paths with a space in file name correctly Windows: 1. Go to address bar 2. Enter "C:\Path\to\file\with space" 3. Press enter Linux/Mac: 1. Go to adress bar 2. Enter "/Path/to/file/with space" 3. Press enter **Actual result:** Issue 1: Brave loads google and performs a search on "https://www.google.com/search?q=dog cat" ![google_search_problem](https://user-images.githubusercontent.com/13398997/39108608-21f42c64-4697-11e8-99fe-c5c23c68e3e9.gif) Issue 2 (Windows): Brave loads google and performs a search on "C:\Path\to\file\with space" ![path_windows_problem](https://user-images.githubusercontent.com/13398997/39108666-72b6915a-4697-11e8-82e8-8f08a5769c21.gif) Issue 2 (Mac/Linux): Brave loads google and performs a search on "/Path/to/file/with space" ![path_mac_problem](https://user-images.githubusercontent.com/13398997/39108670-783fdf78-4697-11e8-8e00-bfb2059aba68.gif) **Expected result:** Issue 1: Brave loads google and performs a search on "dog cat" Issue 2 (Windows): Brave should convert path to "file:///C:/Path/to/file/with%20space". The body of the page should say file not found. Issue 3 (Mac/Linux): Brave should convert the path to "/Path/to/file/with%20space". The body of the page should say file not found. **Reproduces how often:** 100% ### Brave Version **about:brave info:** Brave: 0.22.0 V8: 6.5.254.41 rev: fcf166767398aa54447e0e220ed3b4322e0bb618 Muon: 5.1.2 OS Release: 17.5.0 Update Channel: OS Architecture: x64 OS Platform: macOS Node.js: 7.9.0 libchromiumcontent: 65.0.3325.181 **Reproducible on current live release:** Yes

Topic		Replies	Views
PDFs with English & Arabic file name that contain spaces are not opened in Brave browser Desktop Support windows	2	1002	November 8, 2020
What am I doing wrong with search? This kind of nonsensical result happens frequently. I want to use brave exclusively, but often find myself going back to search in safari Search Support performance	11	735	December 12, 2022
Address Bar "Press Tab to Search" starts searching on space with Google Desktop Support windows	7	2743	October 30, 2019
Space bar not working on Brave Browser Support windows	1	84	March 28, 2024
Downloads not saved when folder or filename changed Desktop Support windows	7	1110	April 9, 2022
URLs entered are discarded and need to be entered twice Desktop Support windows	30	1785	November 13, 2022
Brave cannot open URLs containing umlauts (punny code problem) Mobile Support ios	7	553	September 18, 2020
Problem in the search bar with the most recent update Desktop Support macos	4	1144	April 30, 2019

Session is not restored correctly if URL have spaces

Related Topics