aholub
February 18, 2022, 6:41pm
1
At present, entering a tel://phone-number URI (or clicking on a phone number) redirects me to Google voice. I want phone calls to be made through Facetime, however. Can I change the handler for the tel:// URI to do that?
Brave version: 1.35.101 Chromium: 98.0.4758.87 (Official Build) (arm64)
1 Like
289wk
February 19, 2022, 6:17am
2
aholub ,
Ref.:
opened 07:46PM - 09 Mar 21 UTC
closed 02:21PM - 12 Apr 21 UTC
QA Pass-Win64
QA Pass-macOS
QA Pass-Linux
priority/P4
QA/Yes
release-notes/include
branding
privacy/chromium-redqueen
OS/Desktop
QA/Test-All-Platforms
When you click on a phone number, Chromium now asks if you'd like to use "Brave … Sync" to call from your android device. This text / messaging doesn't make sense in Brave; we don't include this "call from" feature in Brave Sync. This issue is to remove the dialog / feature for the time being
<img width="336" alt="screen_shot_2021-03-08_at_4 33 26_pm" src="https://user-images.githubusercontent.com/76526/110528283-9a501780-80dd-11eb-88e5-789e095d7831.png">
–
If I read that GitHub > Brave Browser (brave-core) issue close enough to correctly . . . Brave developers Disabled a Make a Call From option:
because the message suggested that “Brave Sync” would be involved (“sign into Brave on both devices”).
In order to NOT cause confusion (re that message portion) for the user, the option was Disabled.
Related issue:
brave:master ← brave:disable_sync_phone_call
opened 09:15PM - 06 Apr 21 UTC
Resolves https://github.com/brave/brave-browser/issues/14601, https://github.com… /brave/brave-browser/issues/11526
Share call Chromium feature uses sync to get devices list and uses Google Cloud Messaging to push the call to the Android device. Therefore it is not supported by Brave browser.
The proper way would be to use gn variable `enable_click_to_call`, but setting it to false gives compile errors:
```
../../chrome/browser/sharing/click_to_call/phone_number_regex.cc:43:37: error: use of undeclared identifier 'kClickToCallUI'
if (!base::FeatureList::IsEnabled(kClickToCallUI))
../../chrome/browser/sharing/click_to_call/click_to_call_utils.cc:40:58: error: no member named 'kClickToCallEnabled' in namespace 'prefs'
if (profile && !profile->GetPrefs()->GetBoolean(prefs::kClickToCallEnabled))
~~~~~~~^
../../chrome/browser/sharing/click_to_call/click_to_call_utils.cc:45:58: error: use of undeclared identifier 'kClickToCallUI'
return sharing_service && base::FeatureList::IsEnabled(kClickToCallUI);
^
../../brave/chromium_src/chrome/browser/ui/views/location_bar/../../../../../../../chrome/browser/ui/views/location_bar/location_bar_view.cc:266:38: error: use of undeclared identifier 'kClickToCallUI'
if (base::FeatureList::IsEnabled(kClickToCallUI))
```
By this reason override of `ShouldOfferClickToCallForURL` is used.
## Submitter Checklist:
- [x] I confirm that no security/privacy review [is needed](https://github.com/brave/handbook/blob/master/development/security.md#when-is-a-security-review-needed), or that I have [requested](https://github.com/brave/security/issues/new/choose) one
- [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [ ] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [x] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [ ] Checked the PR locally: `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests`, `npm run lint`, `npm run gn_check`, `npm run tslint`// tested lint only
- [ ] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [ ] A security review [is not needed](https://github.com/brave/handbook/blob/master/development/security.md#when-is-a-security-review-needed), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
1. Put the desktop into the same sync chain with an Android device
2. Open the website which contains `tel:` link, like https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_link_phoneto
3. Click the link with phone number
4. Expected: there is no dialog which choose the device to call from like
–
You would serve your cause well, by asking @Mattches (of Brave Support), to take your issue to the Brave developers involved.
And see if they would develop a fix.
system
March 21, 2022, 6:17am
3
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.
