Chrome PDF viewer cannot be disabled & regex URL bug

Description of the issue:

Selecting to download PDFs instead of opening them in the browser (Content Setting) has no effect.

Steps to Reproduce (add as many as necessary):

  1. Change Setting
  2. Browse to PDF
  3. Hit head on table because the URL parser/regex has a bug that doesn’t account for dashes in TLDs if the content type specified in the header is not supported by the browser, and assumes a URL like http://SOMETHING.pdf-whatever.com/downloads/program.msi should be passed to the internal PDF viewer, which of course fails.

Actual Result (gifs and screenshots are welcome!):

Weird red error bar in PDF viewer.

Expected result:

Download the file to download directory.

Reproduces how often:

100%

Brave Version(about:brave):

about:brave or about:chrome was discontinued a while ago…

I’m using the most current stable release, Is tell you what it is, but I cannot login to the brave community on my desktop because of a bug in the brave community website account backend.

Reproducible on current live release (yes/no): yes

Additional Information:

@bobbob,

We have two open issues for this already:


Also an issue to disable built-in PDF viewer:

Thanks.

What is the problem you’re encountering when attempting to login to Community?

Thanks.

I created a community account, verified it, then could not login. Working now though.