bobbob
November 29, 2018, 7:27pm
1
Description of the issue:
Selecting to download PDFs instead of opening them in the browser (Content Setting) has no effect.
Steps to Reproduce (add as many as necessary):
Change Setting
Browse to PDF
Hit head on table because the URL parser/regex has a bug that doesn’t account for dashes in TLDs if the content type specified in the header is not supported by the browser, and assumes a URL like http://SOMETHING.pdf-whatever.com/downloads/program.msi should be passed to the internal PDF viewer, which of course fails.
Actual Result (gifs and screenshots are welcome!):
Weird red error bar in PDF viewer.
Expected result:
Download the file to download directory.
Reproduces how often:
100%
Brave Version(about:brave):
about:brave or about:chrome was discontinued a while ago…
I’m using the most current stable release, Is tell you what it is, but I cannot login to the brave community on my desktop because of a bug in the brave community website account backend.
Reproducible on current live release (yes/no): yes
Additional Information:
@bobbob ,
We have two open issues for this already:
opened 07:31PM - 28 Nov 18 UTC
closed 10:11PM - 03 Dec 18 UTC
closed/duplicate
closed/invalid
## SEE ISSUE 1531:
#1531
## Description
When I attempt to download any .p… df file, the file is opened by the built in brave PDF viewer even though "Download PDF files instead of automatically opening them in Brave" is turned on (Settings > Advanced Settings > Content Settings > PDF documents).
## Steps to Reproduce
1. Turn "Download PDF files instead of automatically opening them in Brave" on;
2. Close Browser
3. Reopen Browser
4. Open any link to a pdf
ex: http://www.africau.edu/images/default/sample.pdf
## Actual result:
Opens PDF in-browser
## Expected result:
Opens file manager to ask for download location
## Reproduces how often:
Occurs every time
## Brave version (brave://version info)
```
Brave | 0.56.15 Chromium: 70.0.3538.110 (Official Build) (64-bit)
-- | --
Revision | ca97ba107095b2a88cf04f9135463301e685cbb0-refs/branch-heads/3538@{#1094}
OS | Linux
JavaScript | V8 7.0.276.40
Flash | (Disabled)
User Agent | Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36
Command Line | /usr/bin/brave-browser --enable-tab-audio-muting --disable-domain-reliability --disable-chrome-google-url-tracking-client --no-pings --enable-features=EnableEmojiContextMenu,DesktopPWAWindowing,fill-on-account-select,NewExtensionUpdaterService --disable-features=SharedArrayBuffer,DefaultEnableOopRasterization,VizDisplayCompositor,AutofillSaveCardSignInAfterLocalSave,kAutofillServerCommunication --flag-switches-begin --flag-switches-end
Executable Path | /opt/brave.com/brave/brave-browser
Profile Path | /home/alabamavtec/.config/BraveSoftware/Brave-Browser/Default
```
### Reproducible on current release:
- Does it reproduce on brave-browser dev/beta builds?
Have not attempted on dev/beta
### Website problems only:
- Can not disable brave shields for PDF viewer
- On Chromium (Version 70.0.3538.110 (Official Build) Built on Ubuntu, running on Ubuntu 18.10 (64-bit)) with the same settings on, the file manager is opened like it is supposed to and it asks for a download location
opened 05:58PM - 11 Oct 18 UTC
closed 05:27PM - 14 Dec 18 UTC
feature/global-settings
QA Pass-Win64
QA Pass-macOS
QA Pass-Linux
priority/P3
QA/Yes
release-notes/include
QA/Test-Plan-Specified
extension/PDFJS
<!-- Have you searched for similar issues? Before submitting this issue, please … check the open issues and add a note before logging a new issue. Yes.
NOTE THAT THIS IS THE REPOSITORY FOR THE UPCOMING VERSION OF BRAVE. SEE [browser-laptop](https://github.com/brave/browser-laptop)FOR THE CURRENT PRODUCTION VERSION OF BRAVE ON MACOS, WINDOWS AND LINUX.
PLEASE USE THE TEMPLATE BELOW TO PROVIDE INFORMATION ABOUT THE ISSUE.
INSUFFICIENT INFO WILL GET THE ISSUE CLOSED. IT WILL ONLY BE REOPENED AFTER SUFFICIENT INFO IS PROVIDED-->
## Description
I always download pdf instead of opening them in browser. Going to content setting in chrome://setting , toggling the option to download pdf instaed of opening them, doesn't work.Pdf gets opened in browser. Unable to disable Pdf.js extension component via command line.No toggable option in extension setting .It is greyed out.
## Steps to Reproduce
1. Go to chrome://setting.
2. Go to content setting.Then go to the option pdf document.
3. Toggle the option to download pdf instead of opening them in brave. Try to download any pdf file..
## Actual result:
Pdf file is opening inside brave ,instead of getting downloaded.
## Expected result:
Pdf file should be downloaded in brave, instead of opening inside the browser.
## Reproduces how often:
Easily.
## Brave version (chrome://version info)
Brave | 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
-- | --
Revision | cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS | Linux
JavaScript | V8 7.0.276.25
Flash | (Disabled)
User Agent | Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.45 Safari/537.36
Command Line | /usr/bin/brave-browser-beta --enable-tab-audio-muting --disable-domain-reliability --disable-chrome-google-url-tracking-client --no-pings --enable-features=EnableEmojiContextMenu,DesktopPWAWindowing,fill-on-account-select,NewExtensionUpdaterService --disable-features=SharedArrayBuffer,DefaultEnableOopRasterization,VizDisplayCompositor --flag-switches-begin --flag-switches-end
Executable Path | /opt/brave.com/brave-beta/brave-browser-beta
Profile Path | /home/anama/.config/BraveSoftware/Brave-Browser-
### Reproducible on current release:
- Does it reproduce on brave-browser dev/beta builds? Yes.
- Does it reproduce on browser-laptop? No.
### Website problems only:
- Does the issue resolve itself when disabling Brave Shields? No.
- Is the issue reproducible on the latest version of Chrome? No.
### Additional Information
Remove any profile data.
Launch beta version with/Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --show-component-extension-options
Navigate to chrome://extensions.
Also an issue to disable built-in PDF viewer:
opened 05:31PM - 22 Oct 18 UTC
closed 10:14PM - 02 Jan 19 UTC
closed/invalid
feature/global-settings
priority/P3
extension/PDFJS
There should probably be a checkbox somewhere in settings which let's you turn o… f PDFJS and just download PDFs instead.
Thanks.
What is the problem you’re encountering when attempting to login to Community?
bobbob
November 30, 2018, 2:00am
3
Thanks.
I created a community account, verified it, then could not login. Working now though.