Dev tools mobile emulator dark mode not working

Chocoholic · March 27, 2022, 6:14pm

Remove outdated DevTools prefs override for auto dark mode.

brave:master ← brave:issues/20491

opened 12:11PM - 15 Mar 22 UTC

`BraveDevToolsUIBindings` failed to load DevTools UI prefs properly which lead t…o DevTools settings not being persisted, also the sole purpose of this class was to enable dark mode, but now DevTools handles this automatically. Thus it's safe to fully remove this class. Resolves https://github.com/brave/brave-browser/issues/20491 https://user-images.githubusercontent.com/5928869/158374371-9348ac88-f0d4-40ca-83bd-cee61938e475.mp4 ## Submitter Checklist: - [x] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one - [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue - [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above - [x] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html) - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR - [ ] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue - [ ] Checked the PR locally: `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests`, `npm run lint`, `npm run gn_check`, `npm run tslint` - [ ] Ran `git rebase master` (if needed) ## Reviewer Checklist: - [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description - [ ] New files have MPL-2.0 license header - [ ] Adequate test coverage exists to prevent regressions - [ ] Major classes, functions and non-trivial code blocks are well-commented - [ ] Changes in component dependencies are properly reflected in `gn` - [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md) - [ ] Test plan is specified in PR before merging ## After-merge Checklist: - [ ] The associated issue milestone is set to the smallest version that the changes has landed on - [ ] All relevant documentation has been updated, for instance: - [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove) - [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs - [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections - [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes - [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers - [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave - [ ] https://github.com/brave/brave-browser/wiki/QA-Guide - [ ] https://github.com/brave/brave-browser/wiki/P3A ## Test Plan:

Fix is in Nightly and will be uplifted to Beta and Release channels. Thanks for your patience, folks

Fix should be available in Release version soon.

Topic		Replies	Views
Dev Tools Dark Mode Not Working Browser Support windows	15	3097	January 12, 2022
Appearance > Brave Colors > Dark not applied on Linux Desktop Support linux	4	512	July 20, 2023
Roblox and childres' school not displaying in dark mode after update Desktop Support windows	1	205	April 3, 2021
UI glitch when in Dark Mode(Theme) Mobile Support android	4	603	September 16, 2019
DevTools Dark mode does not render chrome properly on NVidia PRIME setups Desktop Support linux	7	480	July 19, 2022
Dark mode not working on sites even though system dark mode is used Browser Support android , macos	3	2453	April 9, 2023
Why was the dark/light mode feature removed from the toolbar menu for Android phones? Mobile Support android	5	632	December 25, 2023
iPhone dark mode not working Mobile Support ios	9	1611	July 12, 2020

Dev tools mobile emulator dark mode not working

Related Topics