Similar to Browser crashes when searching from the address bar on private windows , Brave Nightly on Linux / Pop! OS (ubuntu/debian) installed from apt install brave-browser-nightly
began crashing when you search from the address bar in a private window.
If you type a url into the address bar it works fine.
How can this issue be reproduced?
Open a new private window
Type Browser crashes when searching from the address bar on private windows
into the address bar
Hit enter
Observe that brave nightly crashes both private and normal windows.
Expected result:
It should open the search results for the default search engine.
Brave Version( check About Brave
):
Version 1.60.22 Chromium: 117.0.5938.62 (Official Build) nightly (64-bit)
Additional Information:
Installed from:
# /etc/apt/sources.list.d/brave-browser-nightly.list
deb [signed-by=/usr/share/keyrings/brave-browser-nightly-archive-keyring.gpg arch=amd64] https://brave-browser-apt-nightly.s3.brave.com/ stable main
Tried brave and duck duck go search in private window, both crash.
Searching works fine in a normal window.
Same issue here, but in Windows
it started when I updated mine from 1.60.20 onwards
It also crashes in Tor window as well
I have already submitted an issue in their github:
opened 01:44AM - 15 Sep 23 UTC
IMPORTANT: Your crash has already been automatically reported to our crash syste… m. Please file this bug only if you can provide more information about it.
**Brave Version:** 1.60.23 Chromium: 117.0.5938.62
**Operating System:** Windows NT 10.0.22621
**URL (if applicable) where crash occurred:**
Not URL, but any search keywords
**Can you reproduce this crash?**
Yes, this bug existed starting from 1.60.20 onwards. Brave will not crash when you use it in normal Mode.
**What steps will reproduce this crash? (If it's not reproducible, what were you doing just before the crash?)**
1. Open Brave Browser in either Incognito or Tor Mode.
2. Type and search any keywords or phrases directly in Search bar (URL address bar)
3. Press Enter
My temporary workaround is to type URL of search engine site and search through it. Brave will not crash in Incognito or Tor mode when you type URL format (ex: https://www.example.com) instead of keyword.
****DO NOT CHANGE BELOW THIS LINE****
Crash ID: crash/f9a30200-0209-b80a-0000-000000000000
Saoiray
September 15, 2023, 9:42pm
3
The Github above was closed because it was a duplicate issue that already was open by someone from Brave. The main Github to follow is below.
brave:master
← brave:fix-omnibox-crash
opened 07:02PM - 14 Sep 23 UTC
Resolves https://github.com/brave/brave-browser/issues/32976
<!-- CI-related … labels that can be applied to this PR:
* CI/run-audit-deps (1) - check for known npm/cargo vulnerabilities (audit_deps)
* CI/run-network-audit (1) - run network-audit
* CI/run-upstream-tests - run Chromium unit and browser tests on Linux and Windows (otherwise only on Linux)
* CI/skip - do not run CI builds (except noplatform)
* CI/skip-linux-arm64, CI/skip-linux-x64, CI/skip-android, CI/skip-macos, CI/skip-ios, CI/skip-windows-arm64, CI/skip-windows-x64, CI/skip-windows-x86 - skip CI builds for specific platforms
* CI/skip-upstream-tests - do not run Chromium unit, or browser tests (otherwise only on Linux)
* CI/skip-all-linters - do not run presubmit and lint checks
* CI/storybook-url (1) - deploy storybook and provide a unique URL for each build
(1) applied automatically when some files are changed (see: https://github.com/brave/brave-core/blob/master/.github/labeler.yml)
-->
## Submitter Checklist:
- [ ] I confirm that no [security/privacy review is needed](https://github.com/brave/brave-browser/wiki/Security-reviews) and no other type of reviews are needed, or that I have [requested](https://github.com/brave/reviews/issues/new/choose) them
- [ ] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [ ] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [ ] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [ ] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [ ] Checked the PR locally:
* `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests` [wiki](https://github.com/brave/brave-browser/wiki/Tests)
* `npm run lint`, `npm run presubmit` [wiki](https://github.com/brave/brave-browser/wiki/Presubmit-checks), `npm run gn_check`, `npm run tslint`
- [ ] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
system
Closed
October 15, 2023, 9:43pm
4
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.