Description of the issue: A couple of months ago I had these clean black folders for my bookmarks, but then Brave got an updated and now I have ugly yellow folders again.
How can this issue be reproduced? Because of the update proably.
Expected result: How do I get the black folders for bookmarks back?
Brave Version( check About Brave
): V1.37.113
Additional Information: Please give my clean black bookmark folders back lol
Mattches
Closed
April 12, 2022, 6:52pm
2
No information given.
No support requested.
@yagidev ,
Not entirely sure what youāre referring to here ā are you referring to bookmarks folders that appear in the bookmarks bar (image 1) or in the manager (image 2)?
(image 1)
(image 2)
What version of Windows are you using at this time?
1 Like
How did you get black folders in the first place?
Is that a Theme?
1 Like
Hello! Iām referring to the bookmarks bar (image 1).
Iām using Windows 10 Pro version 10.0.19043.
I donāt know to be honest, I just woke up to that one time, had them for like a week, and one day I wake up to them being yellow again
Can you share a screenshot of how you appear for you now? Additionally, is the way they appear in my screenshot the way you are expecting them to look?
Iām also curious as @Passenger asked ā did/do you have any themes installed in the browser at this time?
1 Like
No themes and no black folders ever. Everything looks like it always did for me.
Also no particular problem, except I would like to have black folders (never having heard of that before).
1 Like
This is how they appear now.
The ones in your screenshot are white, mine back then looked something like this:
I did not have any themes installed, nor do I have any installed now.
Apologies ā this is actually an old intentional design change. I guess it was old enough that I forgot itād happened
brave:master
ā brave:bsc-update-folder-icons
opened 08:08AM - 10 Sep 21 UTC
- Windows icons are back to yellow
- macOS and Linux use a gray colored icon (Lā¦ inux has slightly different dimensions)
Having a proper icon solves the visibility issue for sub-folders on private window.
Fixes https://github.com/brave/brave-browser/issues/17463
Fixes https://github.com/brave/brave-browser/issues/17214
## Test plan (needs to be ran on macOS, Windows, and Linux)
1. New profile
2. Hamburger menu => Bookmarks => Show bookmarks
3. Add a few folders to the bookmarks toolbar
4. Add a few subfolders (to cover test plan in https://github.com/brave/brave-browser/issues/17214)
5. Verify images look like below (see each OS screenshot) in Regular window
6. Opening a new Private window should look like dark mode
7. Sub-folders in bookmarks toolbar in private mode should be like light mode
### Windows


### macOS
<img width="720" alt="Screen Shot 2021-09-11 at 9 05 41 AM" src="https://user-images.githubusercontent.com/6786187/132929207-8d159dc8-7141-4e42-b125-8a515363c6cb.png">
<img width="716" alt="Screen Shot 2021-09-11 at 9 05 58 AM" src="https://user-images.githubusercontent.com/6786187/132929210-e7b44745-6214-4ec0-b8f1-577a207f9c03.png">
## Linux


## Submitter Checklist:
- [x] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one
- [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [x] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [ ] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [ ] Checked the PR locally: `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests`, `npm run lint`, `npm run gn_check`, `npm run tslint`
- [x] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [x] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [x] Test plan is specified in PR before merging
## After-merge Checklist:
- [x] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
@yagidev if this is just now happening for you, you must have been behind several updates.
1 Like
Oh no, Iām not behind with any updates.
Iām just hopeful.
This whole time I was hoping Iād get those folders back.
So, is there any way to get them back?
Or you can at least like make a suggestion as a mod to the team to add a feature that letās you choose between those two variants of folders?
Thanks!
Youāre welcome to open a Feature Request here on Community for it.
You stated that this issue occurred after a recent update. However, this particular change in the folder icons happened several updates ago. So you were at one point behind on updates. You appear to be using the latest version now, however.
1 Like
Sure thing, thanks for the help!
Are they usually quick on adding new features if they are wanted or do they take a while?
@yagidev ,
It will likely take a while if its decided to implement at all. The unfortunate nature of software development.
Given the amount of time it took to add custom backgrounds and how long it has been since people have been asking for vertical tabs, āthe unfortunate nature of software developmentā feels like a poor excuse to avoid saying āwe donāt careā.
Wellā¦ hopefully they can add this one 'cause I donāt think it would be that hard.