Why do we have 'display: none !important' on 'div:last-of-type'?

Browser Support Desktop Support
1

Description of the issue:
Brave hides the vimium “overlay”.

I’m using the vimium extension, but Brave seems to hide the overlay from that extension.

When you press f, vimium adds a div to the html with vimiumHintMarkerContainer id. When I inspect it I can see this CSS applied to it:

html >   div ~ div:last-of-type { 
   display: none !important 
}

From this in the HEAD:

<style>html >   div ~ div:last-of-type { display: none !important }</style>

Any reason for having that?

Steps to Reproduce (add as many as necessary): 1. 2. 3.
To reproduce:

  1. Install vimium
  2. Go to google and search for something.
  3. Press f on your keyboard

Actual Result (gifs and screenshots are welcome!):
vimium overlay not visible (display: none !important)

Expected result:
Be able to see the vimium overlay

Reproduces how often:
everytime

Brave Version(about:brave):
Version 0.65.118 Chromium: 75.0.3770.80 (Official Build) (64-bit)

Reproducible on current live release (yes/no):
Yes? My browser is up to date if that’s what you are asking.

Additional Information:
macOS Mojave - 10.14.2

2

@radi,
Thanks for reaching out to us and great write-up.
On my end, using macOS Mojave (latest) on Brave Release, I’m able to see the overlay after hitting F on the keyboard:

image
image2852×1542 769 KB

You say that it does work with Shields down but not when they’re up – would you mind showing/telling me what your Shields settings are set to?

1 Like
3

I didn’t say that :smiley:

However, when you said that I played with that and also tried the extension in incognito mode and it worked. So the issue was another extension that was conflicting with vimium

Thank you for taking the time to debug the “issue” with me!

4

Hahaha – And so you didn’t! Maybe the quotation marks here:

Should instead be around “debug” :stuck_out_tongue:
Just for the knowledge and in the event another users encounters the same issue – can I ask which extension was causing the issue with vimium?
Don’t hesitate to reach out if you have any further questions or concerns!

1 Like
5

@Mattches, I think it’s this one:

Lolli: Earn Bitcoin When You Shop

1 Like
6

Appreciate the info @radi!

1 Like