Description of the issue:
EDIT 1: I tried using other search engines via the shortcut, like :br, It still crashed EDIT 2: I have all flags set to default EDIT 3 -
Crash from Friday, September 15, 2023 at 6:38:51 PM
Status
Uploaded Crash Report ID
Upload Time
The command log (linux) just says this:
/usr/bin/brave-browser-nightly: line 48: 9933 Segmentation fault "$HERE/brave" "$@"
How can this issue be reproduced?
Open brave-nightly (Use version 1.60.22)
Open a new incognito window/tab
Type something in the search bar
Hit enter.
Expected result:
Brave Version:
Saoiray
September 15, 2023, 12:42pm
2
@Mattches I’m able to replicate this. Crash reports from when it happened to me are below. This is on the current version of Nightly, 1.60.22:
Status:
Uploaded
Uploaded Crash Report ID:
146b0300-0209-b80a-0000-000000000000
Upload Time:
Friday, September 15, 2023 at 8:41:59 AM
Provide additional details
Status:
Uploaded
Uploaded Crash Report ID:
136b0300-0209-b80a-0000-000000000000
Upload Time:
Friday, September 15, 2023 at 8:41:59 AM
Saoiray
September 15, 2023, 12:45pm
3
@itsnoone just a FYI for the future, any time you report an issue with the browser crashing, it’s helpful if you can share Uploaded Crash Report ID. You can get this at brave://crashes. If it says Send Now when you go there, you’ll have to hit that and close the browser for like 30 seconds to let it upload. Then when you go back, it will have it.
aah, i did try that, but didn’t close the browser… thx!
Yep I’m seeing this too — thank you for the report guys
Looks like it’s known and fixed in the next Nightly update:
brave:master ← brave:fix-omnibox-crash
opened 07:02PM - 14 Sep 23 UTC
Resolves https://github.com/brave/brave-browser/issues/32976
<!-- CI-related … labels that can be applied to this PR:
* CI/run-audit-deps (1) - check for known npm/cargo vulnerabilities (audit_deps)
* CI/run-network-audit (1) - run network-audit
* CI/run-upstream-tests - run Chromium unit and browser tests on Linux and Windows (otherwise only on Linux)
* CI/skip - do not run CI builds (except noplatform)
* CI/skip-linux-arm64, CI/skip-linux-x64, CI/skip-android, CI/skip-macos, CI/skip-ios, CI/skip-windows-arm64, CI/skip-windows-x64, CI/skip-windows-x86 - skip CI builds for specific platforms
* CI/skip-upstream-tests - do not run Chromium unit, or browser tests (otherwise only on Linux)
* CI/skip-all-linters - do not run presubmit and lint checks
* CI/storybook-url (1) - deploy storybook and provide a unique URL for each build
(1) applied automatically when some files are changed (see: https://github.com/brave/brave-core/blob/master/.github/labeler.yml)
-->
## Submitter Checklist:
- [ ] I confirm that no [security/privacy review is needed](https://github.com/brave/brave-browser/wiki/Security-reviews) and no other type of reviews are needed, or that I have [requested](https://github.com/brave/reviews/issues/new/choose) them
- [ ] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [ ] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [ ] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [ ] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [ ] Checked the PR locally:
* `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests` [wiki](https://github.com/brave/brave-browser/wiki/Tests)
* `npm run lint`, `npm run presubmit` [wiki](https://github.com/brave/brave-browser/wiki/Presubmit-checks), `npm run gn_check`, `npm run tslint`
- [ ] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan: