Description of the issue:
How can this issue be reproduced?
Open brave browser on an android device
Only Open Links In Current Tab Group (settings > appearance > enable Only Open Links In Current Tab Group)
Open links in current tab group
Ignores setting and opens links in a new window.
Expected result:
Brave Version: Brave 1.57.62, Chromium 116.0.5845.180
Samsung Galaxy S10e
Additional Information: This issue started after the new update.
Just tested this on my end and it seems to work for me as intended. Would it be possible for you to share a short screen recording of the behavior?
Blooop
September 18, 2023, 3:12pm
3
hi, @Mattches , i’ve been having the same issue @soulsilk9503 encountered on my Brave mobile app. right-clicking a link and opening it in the same tab group works as intended, but directly clicking on a link that is expected to open in the same tab group opens a new window instead.
here’s a quick screen recording of this behavior. i’m on the same Brave version as OP.
Brave Version: Brave 1.57.62, Chromium 116.0.5845.180 on Samsung Galaxy S23 Ultra
would appreciate your support on this one, thanks!
@Blooop ,Only open links in current tab group) that needs to be addressed.
I’ve forwarded this information to the Android team for review.
So I’ve opened an issue for this here:
opened 06:55PM - 18 Sep 23 UTC
feature/tabs-bar
feature/settings
OS/Android
<!-- Have you searched for similar issues? Before submitting this issue, please … check the open issues and add a note before logging a new issue.
PLEASE USE THE TEMPLATE BELOW TO PROVIDE INFORMATION ABOUT THE ISSUE.
INSUFFICIENT INFO WILL GET THE ISSUE CLOSED. IT WILL ONLY BE REOPENED AFTER SUFFICIENT INFO IS PROVIDED-->
## Description
The `Only open links in current tab group` in `Settings --> Appearance` on Android does not work. Whether the option is enabled or disabled, tapping on a link to open it always opens the link in a new tab group. The only way to get a link to open in the same tab group is to long-press and select `Open new tab in group`.
I have users reporting this same behavior and found that I can reproduce every time when testing. Screen recording of the behavior here:
https://github.com/brave/brave-browser/assets/3299098/21015644-2b03-4e47-a1b6-7cace14bd1ff
This does not reproduce in Beta so maybe we just need to wait for the next update but thought it was worth looking into regardless.
## Steps to reproduce
1. Ensure that `Only open links in current tab group` in `Settings --> Appearance` is enabled
2. Relaunch browser when prompted
3. Tap any link on any site in any tab group
## Actual result
Link is opened in a new tab group
## Expected result
Link should open in current tab group
## Issue reproduces how often
Every time
## Version/Channel Information:
- Can you reproduce this issue with the current Play Store version? Y
- Can you reproduce this issue with the current Play Store Beta version? N
- Can you reproduce this issue with the current Play Store Nightly version? N
## Brave version
v1.57.62
### Additional information
User reports:
https://community.brave.com/t/new-links-dont-open-in-current-tab-group/505515/4
It is worth mentioning that this issue does not reproduce in the Beta version of the browser — so it may already be fixed with the next browser update. Will keep an eye out on this to see.
1 Like
Annnnnd one last update — it appears that this was in fact already known and will be fixed in the next browser update:
brave:master ← brave:android_open_link_fix
opened 10:30PM - 11 Sep 23 UTC
Resolves https://github.com/brave/brave-browser/issues/32853
Resolves https://g… ithub.com/brave/brave-browser/issues/32854
<!-- CI-related labels that can be applied to this PR:
* CI/run-audit-deps (1) - check for known npm/cargo vulnerabilities (audit_deps)
* CI/run-network-audit (1) - run network-audit
* CI/run-upstream-tests - run Chromium unit and browser tests on Linux and Windows (otherwise only on Linux)
* CI/skip - do not run CI builds (except noplatform)
* CI/skip-linux-arm64, CI/skip-linux-x64, CI/skip-android, CI/skip-macos, CI/skip-ios, CI/skip-windows-arm64, CI/skip-windows-x64, CI/skip-windows-x86 - skip CI builds for specific platforms
* CI/skip-upstream-tests - do not run Chromium unit, or browser tests (otherwise only on Linux)
* CI/skip-all-linters - do not run presubmit and lint checks
* CI/storybook-url (1) - deploy storybook and provide a unique URL for each build
(1) applied automatically when some files are changed (see: https://github.com/brave/brave-core/blob/master/.github/labeler.yml)
-->
## Submitter Checklist:
- [x] I confirm that no [security/privacy review is needed](https://github.com/brave/brave-browser/wiki/Security-reviews) and no other type of reviews are needed, or that I have [requested](https://github.com/brave/reviews/issues/new/choose) them
- [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [ ] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [ ] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [ ] Checked the PR locally:
* `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests` [wiki](https://github.com/brave/brave-browser/wiki/Tests)
* `npm run lint`, `npm run presubmit` [wiki](https://github.com/brave/brave-browser/wiki/Presubmit-checks), `npm run gn_check`, `npm run tslint`
- [ ] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
Blooop
September 19, 2023, 10:33am
7
that’s great! thank you so much for the update!
system
October 19, 2023, 10:33am
8
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.