Brave clearing cookies when I close tabs

Mattches · April 22, 2022, 6:04pm

We an issue

github.com/brave/brave-browser

Global "clear cookies when you close all windows" setting conflicts with 1PES

opened 05:06AM - 22 Apr 22 UTC

closed 03:49PM - 22 Apr 22 UTC

goodov

QA/Yes release-notes/exclude OS/Desktop

https://community.brave.com/t/brave-clearing-cookies-when-i-close-tabs/366275 … > I have it set to do so in Settings (clear all cookies upon closing all windows). Beginning today, Brave seems to be deleting cookies as soon as I close the tab even if the rest of the window is still open, meaning if I log into a site and then close that tab, I need to login to that site again. > > Steps to Reproduce: > > 1. I login to a site. > 2. I close the tab with that site while leaving the window + other tabs open. > 3. I open that site again in a new tab. > Actual Result: The site opens in the tab with me signed out. I need to sign-in again. > > Expected result: Prior to today, the site would have left me signed in until I closed the entire browser window. >

and a fix for this on the way:

github.com/brave/brave-core

Don't enable 1PES everywhere when global SESSION_ONLY mode is enabled.

brave:master ← brave:issues/22493

opened 06:38AM - 22 Apr 22 UTC

goodov

+94 -5

Don't enable 1PES when SESSION_ONLY mode is applied via `*, *` content settings …patterns. Resolves https://github.com/brave/brave-browser/issues/22493 ## Submitter Checklist: - [x] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one - [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue - [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above - [x] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html) - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR - [ ] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue - [ ] Checked the PR locally: `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests`, `npm run lint`, `npm run gn_check`, `npm run tslint` - [ ] Ran `git rebase master` (if needed) ## Reviewer Checklist: - [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description - [ ] New files have MPL-2.0 license header - [ ] Adequate test coverage exists to prevent regressions - [ ] Major classes, functions and non-trivial code blocks are well-commented - [ ] Changes in component dependencies are properly reflected in `gn` - [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md) - [ ] Test plan is specified in PR before merging ## After-merge Checklist: - [ ] The associated issue milestone is set to the smallest version that the changes has landed on - [ ] All relevant documentation has been updated, for instance: - [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove) - [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs - [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections - [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes - [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers - [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave - [ ] https://github.com/brave/brave-browser/wiki/QA-Guide - [ ] https://github.com/brave/brave-browser/wiki/P3A ## Test Plan:

Topic		Replies	Views
Logsout when tab is closed instead of window Desktop Support windows	5	698	May 29, 2022
Brave not deleting cookies on exit Desktop Support macos	7	604	November 9, 2023
Brave keeps deleting cookies when closing browser Desktop Support windows	3	2503	September 9, 2021
Login cookies are getting deleted on Tab close Web Compatibility	5	551	May 26, 2022
Some BAT disappears and allowed cookies are deleted when all tabs are closed Desktop Support windows	1	262	March 1, 2021
Sites that clear cookies when you close them Desktop Support linux	2	432	December 21, 2022
Pinned tabs wiped & undeleted cookies Desktop Support windows	2	157	June 14, 2024
Newly discovered feature "Always clear cookies when windows are closed" doesn't work Desktop Support windows	4	908	August 15, 2021

Brave clearing cookies when I close tabs

Related topics