Hello World,
PLEASE I’m begging you , does anyone what file brave uses for the icon of bookmark folders and where that would be located on linux(arch linux if it matters)?!?!
I seriously can’t stand that shitty silver icon anymore and need to change it to something more decent/classic!
Thank you.
1 Like
Hello @VIKINGS
could you share screen shoot of where you see that icon ?
Sure @justsomeone1 , here is what I’m currently seeing in brave on the bookmarks toolbar and totally hate :
And here is an example of something beautiful that I’d like to go to:
1 Like
unfortuntly there was option in chrome to change it back to yellow but it does not work any more
https://www.reddit.com/r/chrome/comments/1bl2vqh/getting_chrome_yellow_bookmark_folders_back_as_of/
this one on chrome who disable this feature
@VIKINGS what version of Brave are you using?
@Mattches you have any insight on this? To point out the posts above, they seem to be complaining that folders are silver/gray in color and not the usual yellow/gold. So way of changing it to desired yellow or whatever.
I noticed Github open for something similar from last year, but not sure if I’m seeing right in terms of them intentionally guiding to design mentioned by OP or if they were building out so would be yellow? Github issues are below (seems they were merged together):
opened 05:56PM - 07 Sep 23 UTC
closed 01:32AM - 11 Sep 23 UTC
feature/user-interface
feature/bookmarks
OS/Windows
QA Pass-Win64
QA Pass-macOS
QA Pass-Linux
priority/P2
QA/Yes
release-notes/exclude
OS/Desktop
QA/Test-All-Platforms
## Description
Latest Nightly has updated the icons for folders in the bookmar… ks toolbar. This is a controversial change - I believe unintentionally changed by either by having chrome://flags/#chrome-refresh-2023 enabled OR after https://github.com/brave/brave-core/pull/19819 was merged.
## Steps to Reproduce
1. Launch latest Nightly on Windows
## Actual result:
Shows as outlined
![image](https://github.com/brave/brave-browser/assets/4733304/9ff79a34-0b2d-4d83-a9a0-41e6b2332d7e)
## Expected result:
Should be yellow on Windows and Gray (gradient) on macOS/Linux
![image](https://github.com/brave/brave-browser/assets/4733304/aa362b86-f742-496f-aec3-57d2bca69377)
## Reproduces how often:
100%
## Brave version (brave://version info)
## Version/Channel Information:
- Can you reproduce this issue with the current release? N (1.57)
- Can you reproduce this issue with the beta channel? N (no on 1.58; yes on 1.59)
- Can you reproduce this issue with the nightly channel? Y (1.60)
brave:master
← brave:bookmark-icons
opened 12:38AM - 08 Sep 23 UTC
Resolves https://github.com/brave/brave-browser/issues/32851
<!-- CI-related … labels that can be applied to this PR:
* CI/run-audit-deps (1) - check for known npm/cargo vulnerabilities (audit_deps)
* CI/run-network-audit (1) - run network-audit
* CI/run-upstream-tests - run Chromium unit and browser tests on Linux and Windows (otherwise only on Linux)
* CI/skip - do not run CI builds (except noplatform)
* CI/skip-linux-arm64, CI/skip-linux-x64, CI/skip-android, CI/skip-macos, CI/skip-ios, CI/skip-windows-arm64, CI/skip-windows-x64, CI/skip-windows-x86 - skip CI builds for specific platforms
* CI/skip-upstream-tests - do not run Chromium unit, or browser tests (otherwise only on Linux)
* CI/skip-all-linters - do not run presubmit and lint checks
* CI/storybook-url (1) - deploy storybook and provide a unique URL for each build
(1) applied automatically when some files are changed (see: https://github.com/brave/brave-core/blob/master/.github/labeler.yml)
-->
## Submitter Checklist:
- [ ] I confirm that no [security/privacy review is needed](https://github.com/brave/brave-browser/wiki/Security-reviews) and no other type of reviews are needed, or that I have [requested](https://github.com/brave/reviews/issues/new/choose) them
- [ ] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [ ] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [ ] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [ ] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [ ] Checked the PR locally:
* `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests` [wiki](https://github.com/brave/brave-browser/wiki/Tests)
* `npm run lint`, `npm run presubmit` [wiki](https://github.com/brave/brave-browser/wiki/Presubmit-checks), `npm run gn_check`, `npm run tslint`
- [ ] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
1. Bookmark icons should not have changed, either in the app menu or in the bookmarks bar
2 Likes
Yeah, I just want the nice yellow aesthetic back @Saoiray , it doesn’t have to look exactly like the ones in the image I posted.
My Brave is version 1.68.141 Chromium: 127.0.6533.120 (Official Build) (64-bit)
And yeah @justsomeone1 I know in the past you could change it back with flags and stuff, that is why I am saying F it and F them too(whoever made these changes and disables the flags), and I am asking specifically about the actual files.
Because whatever retarded changes they decide to make these still need to be loaded from files that are stored on my device, right? So if I can find and access these files I can change them and thus change what brave loads and how it looks, no?
1 Like
For Windows users, these icons were changed to the “yellow”/“color” version of the icons — this was what the issue @Saoiray linked to was addressing. Linux and macOS users will see the gray toned icons you see currently. While I believe we have plans to implement the option to change the way these icons display in future releases, for now there is no way to change their appearance.
1 Like
system
Closed
October 16, 2024, 6:07am
9
This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.