The thread says: “User should be able to remove rewards data (auto contribute, donation, tipping) and remove payment data (previous payments). This should delete the data on disk.”
So no, the reset option only resets to zero your wallet, the “Reset Brave Rewards data…” only clears “auto contribute, donation, tipping, etc” data.
As for:
“We should stop logging rewards and ads logs into file on the disk. We should also remove all existing logs that are there. Let’s add a flag to rewards flag to enable logging, so that internal people can still enable them and audit them”
As i understand, before the rewards-internals log feature this info was saved in disk and this feature was not disable until this update.
thanks for your time and i read the github
and the word previous payments was very confusing that why i asked
this is not clear
We should stop logging rewards and ads logs into file on the disk. We should also remove all existing logs that are there. Let’s add a flag to rewards flag to enable logging, so that internal people can still enable them and audit them
reward system before this update was relay on logs like not ads show up before 15 mn pass and checking the las 24 hours if there 20 ads served or less and interestted categoury and so much info
if it not looged on disk does it mean it will be on server or in memory and if it will be in memory that will add more memory madness
logs are managed locally. Logs files only function is to serve as a record book, they keep a record of everything that happens (in this case) in your browser, not only the info you had already understand but also crashes and those stuff.
This are used by developers to get an idea of where an error is. Like i said, before rewards-internals logs feature this was saved in disk (as we can read on the github thread), but now it´s innecesary for normal users like us, one because you can generate a new logs file when you want and two because it only generates more files in your machine. So, they are removing this, but developers will still have access to reactivate this feature for development.
So in summary, it´s local, but for users like us this file will be generated only when we explicitly generate it.
@ambrocioisaias2808 is pretty much 100% correct on all this. There is nothing to suspect here. Logs are managed, stored and accessed locally. We disabled loggingbecause of the fact that the logs had contained sensitive data that the team wasn’t aware of – disabling the logs allowed us to preserve user privacy. Further, any logs that we had collected from users for troubleshooting/diagnosing issues were deleted/erased (again, because of #11260).
