Description of the issue:
Many ads appear at the bottom of the article on the iOS version of Brave.
Exact URL of the website in question:
“https://thelibertydaily.com/fantastic-deal-on-mypillow-mattresses-foam-and-two-sided-encased-coil-quilted-mattresses-50-off/ ”
Screenshot of the ad as it appears in Brave
Did the issue present with default Shields settings ? (yes/no)
Yes
Does the site function as expected when Shields are turned off?
Yes
Brave version (check About Brave):
Brave iOS 1.44.1
Fixes for ios cosmetic filtering is incoming, lets wait for this to land first.
brave:development ← brave:js/improve-cosmetic-filters-injection
opened 03:47PM - 20 Oct 22 UTC
## Summary of Changes
This pull request fixes #6241
Security ticket: htt… ps://github.com/brave/security/issues/1079
## Submitter Checklist:
- [x] *Unit Tests* are updated to cover new or changed functionality
- [x] User-facing strings use `NSLocalizableString()`
- [x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes
## Test Plan:
## Screenshots:
## Reviewer Checklist:
- [ ] Issues include necessary QA labels:
- `QA/(Yes|No)`
- `bug` / `enhancement`
- [ ] Necessary [security reviews](https://github.com/brave/security/issues/new/choose) have taken place.
- [ ] Adequate unit test coverage exists to prevent regressions.
- [ ] Adequate test plan exists for QA to validate (if applicable).
- [ ] Issue and pull request is assigned to a milestone (should happen at merge time).
1 Like
@fanboynz
Version 1.45 of iOS was just released and contains the fix you mentioned. However, the ads are still appearing on the page. I did do a refreh on the page and tried clearing everything.
“https://thelibertydaily.com/fantastic-deal-on-mypillow-mattresses-foam-and-two-sided-encased-coil-quilted-mattresses-50-off/ ”
Still a few outstanding issues re: adblocking. Discussing internally.
system
December 15, 2022, 4:03am
#5
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.
