The <Escape> key in the bookmark dialog modal overlay window

[doru001]

The escape key in the bookmark dialog window now saves changes, just like <Enter>.
It should leave saved data unmodified.
This issue replaces another strange issue, which made me lose bookmarks and is reported here:

When I add a new bookmark, and it is already added, pressing escape deletes the bookmark. It should not

Description of the issue: When I press Ctrl-D to add a bookmark, and the bookmark is already added, I press escape to cancel. But this deletes the bookmark. Cancel means abort, not delete. I have lost a lot of bookmarks this way. How can this issue be reproduced? Add a bookmark and verify that it is added. Add the same bookmark again with Ctrl-D and hit escape Now see your bookmarks, and you can see the bookmark has been deleted. Expected result: I would expect the bookmark to not be dele…

Warning: hitting Escape on Bookmark edit dialogue will delete bookmark

Noticed this myself and was alarmed. If you have an existing bookmark, and you ‘edit’ it (either by clicking the Bookmark toolbar button, or pressing Ctrl+D) and then press Escape to dismiss the editing box – the bookmark will be deleted. Expected behavior would be to just dismiss the box and leave the bookmark intact. Did some searching and it turns out that this is not a Brave issue, it is an issue with Chromium upstream: https://bugs.chromium.org/p/chromium/issues/detail?id=1202408 But fi…

Brave Version 1.31.88 Chromium: 95.0.4638.69 (Official Build) (64-bit)

[JimB1]

I’ll take a closer look at this later, but the original bug, and the fix, were from upstream Chromium; it’s very likely that an issue here would be as well and should probably get reported into the Chromium bug tracker.