Pressing Esc Key on the Private history popup closes window

Browser Support Desktop Support
, , , ,
1

Description of the issue:
How can this issue be reproduced?

  1. Open New private window
  2. press CTRL + H
  3. Pop-up appears “Sites you visited…”
  4. Press ESC button
  5. All private windows are closed

Expected result:

Pressing ESC button should close the pop-up, not close all private windows. In Chrome the behavior is normal.

Brave Version(1.75.178):

2

On a Mac, step 2, key combination: Command + Y

On a Mac, Brave Browsing History is not stored when using a Private Window.

3

@derineryilmaz I believe this is intentional as it aligns with the options. The Sites you visited prompt is below:

image
image379×235 11.6 KB

Your options are Got It or Close Private. Hitting ESC is hitting the Close Private button. Just as hitting Enter dismisses the message and keeps you in Private.

Keep in mind ESC usually aligns with the second option. Many windows tend to have it default to Go Back or Cancel, but it’s not a guarantee.

Anyway, can see this is a feedback or suggestion that Brave should perhaps consider, but at least wanted to point out that this at least seems to be the intentional design.

4

Pressing Esc should never initiate a destructive action. It ought to dismiss the popup.

1 Like
5

@derineryilmaz @Mythical5th my reply aside, I did look to see if it happens in Chrome as well. But I see the design works differently there where ESC works as you are saying you’d like to see it behave here.

So this isn’t an inherited issue from Chromium. I was going to create a Github issue on this, but I see there’s already one that was created back in 2022. I’m going to tag @Mattches to get eyes on it and see if they can ping the appropriate devs.

6

Yeah can reproduce. Went ahead and commented in that issue and included this report as well. Hopefully someone will take a look soon.