Aman_M
March 9, 2023, 1:54pm
1
Briefly describe your issue:
Tipping Banner in Nightly shows “Server connection error” and brave://rewards/
perpetually loads vBAT balance without success. Extension panal from BAT triangle shows correct vBAT balance though. So are we in the process of removing vBATs from Nightly already? @Mattches
What Operating System and Brave version are you using (Menu --> About Brave
)?
Brave
1.51.16 Chromium: 111.0.5563.64 (Official Build) nightly (64-bit)
Revision
c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995 }
OS
Windows 10 Version 22H2 (Build 19045.2604)
Is your Brave Rewards Profile currently verified? (yes/no)
No
What date did you connect a your Brave Rewards Profile?
NA
Have you been able to successfully receive payments in the past?
In distant past, yes.
Are you using a VPN? (yes/no)
No
Are you in a supported region (see here for list of supported regions)?
No
Does your device pass the SafteyNet check (Android only)?
NA
Have you manually turned off Auto-contribute on all of your devices?
Yes
Thanks @Aman_M , is this still an issue for you?
Aman_M
March 9, 2023, 4:16pm
3
Yeah @steeven I’m still seeing this. Is this not expected?
Hi @Aman_M I am able to reproduce the issue on Nightly 1.51.16
Let me look into this.
Aman_M
March 9, 2023, 4:28pm
5
Good to know @SaltyBanana and hopefully this is just a bug introduced by the changes in tipping being worked upon.
Hi @Aman_M
Update: Can confirm that it mostly likely related to vBAT expiry.
With a verified account I am able to send tips.
Aman_M
March 9, 2023, 4:32pm
7
But @SaltyBanana the BAT triangle extension panel correctly shows my vBAT balance so I’m guessing my vBATs haven’t expired yet. Or is it that vBATs will expire in Nightly first?
@Aman_M Asking our team if this is intended behavior.
2 Likes
Aman_M
March 10, 2023, 3:55pm
9
Is there any update @SaltyBanana ?
This issue is currently open and should be resolved in the next update. Thanks again!
brave:master
← brave:sszaloki-28793-audit-network-errors-and-their-ui-effects
opened 05:29AM - 06 Mar 23 UTC
Resolves https://github.com/brave/brave-browser/issues/28793.
<!-- CI-related… labels that can be applied to this PR:
* CI/run-audit-deps (1) - check for known npm/cargo vulnerabilities (audit_deps)
* CI/run-draft - run CI builds on a draft PR (otherwise only on non-draft PRs)
* CI/run-network-audit (1) - run network-audit
* CI/run-upstream-tests - run Chromium unit and browser tests on Linux and Windows (otherwise only on Linux)
* CI/skip - do not run CI builds (except noplatform)
* CI/skip-linux, CI/skip-android, CI/skip-macos, CI/skip-ios, CI/skip-windows, CI/skip-windows-x86 - skip CI builds for specific platforms
* CI/skip-upstream-tests - do not run Chromium unit, or browser tests (otherwise only on Linux)
* CI/storybook-url (1) - deploy storybook and provide a unique URL for each build
(1) applied automatically when some files are changed (see: https://github.com/brave/brave-core/blob/master/.github/labeler.yml)
-->
## Submitter Checklist:
- [ ] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one
- [ ] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [ ] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [ ] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [ ] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [ ] Checked the PR locally:
* `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests` [wiki](https://github.com/brave/brave-browser/wiki/Tests)
* `npm run lint`, `npm run presubmit` [wiki](https://github.com/brave/brave-browser/wiki/Presubmit-checks), `npm run gn_check`, `npm run tslint`
- [ ] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
Before enabling Rewards, there's no balance info displayed on Rewards Internals anymore:

After enabling Rewards but before connecting a custodial wallet service, we only display vBAT balance on Rewards Internals (and the `Connect account` UI on the Rewards page/Rewards panel/Rewards NTP widget):

After connecting a custodial wallet service, we display both the vBAT/external wallet balance on Rewards Internals (and show the total balance on the Rewards page/Rewards panel/Rewards NTP widget):

In the logged out state, we only show vBAT balance on Rewards Internals (and the `Logged out` UI on the Rewards page/Rewards panel/Rewards NTP widget, including the tipping banner — `:( You are currently logged out.`):

On an error coming from a custodial wallet service balance endpoint, we show a spinner for **both** the vBAT/external wallet balance on Rewards Internals (and a spinner on the Rewards page/Rewards panel/Rewards NTP widget, except for the tipping banner, where we show the `Server connection error` UI):

2 Likes
Aman_M
March 10, 2023, 5:06pm
11
Cool. Thanks for the update.
1 Like
Aman_M
March 14, 2023, 10:13am
12
Just to update, it’s working now.
1 Like
I’m having the same issue. I’ve updated to Version 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit). Still I am getting the same error.
@steeven
@SaltyBanana
What’s the version you have updated to?
Hi @Aakarsh_k this change was merged with Nightly 1.51
Okay. Thanks. But when I update, it shows its up to date. When is Nightly 1.51 shipping?
Umm, I guess it already has. mine rus 1.51.48 already.
Aman_M
March 23, 2023, 6:41pm
18
@Aakarsh_k The fix was uplifted to v1.50.93 as well-
You should check if there is an update available in your Brave Beta.
Thank you all. It’s working now. I didn’t do anything, it started working on it’s own. I’m running Version 1.50.101.
2 Likes
system
Closed
April 23, 2023, 4:31am
20
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.