Description of the issue:
On the FAQ pages under the question: ‘ Are all ads blocked or can users allow some or all?
"
The response is “ Ads and trackers are blocked by default. You can allow ads and trackers in the preferences panel. ”
As the following white-list knowingly exists in the code, that would make the above statement misleading by means of omission.
“TrackingProtectionService::TrackingProtectionService()
: tracking_protection_client_(new CTPParser()),
// See comment in tracking_protection_service.h for white_list_
white_list_({
“connect DOT facebook DOT net”,
“connect DOT facebook DOT com”,
“staticxx DOT facebook DOT com”,
“www DOT facebook DOT com”,
“scontent DOT xx DOT fbcdn DOT net”,
“pbs DOT twimg DOT com”,
“scontent-sjc2-1 DOT xx DOT fbcdn DOT net”,
“platform DOT twitter DOT com”,
“syndication DOT twitter DOT com”,
“cdn DOT syndication DOT twimg DOT com”
}),
weak_factory_(this) {
DETACH_FROM_SEQUENCE(sequence_checker_);
}”
Steps to Reproduce (add as many as necessary): 1. 2. 3.
-
Go to FAQ page and find above mentioned Q&A:
https://brave.com/faq/ -
Go too Gethub showing snip of current code and notes:
https://github.com/brave/brave-core/blob/master/components/brave_shields/browser/tracking_protection_service.cc#L33
https://github.com/brave/brave-browser/issues/1108
3)Conclude that these two facts contradict, if end user, attempt to contain anger that you were mislead and the excuse is poor.
Actual Result (gifs and screenshots are welcome!):
Being tracked/mislead
Expected result:
Not being tracked/not being mislead
Reproduces how often:
Continuously
Brave Version(about:brave):
Current Live
Reproducible on current live release (yes/no):
Yes
Additional Information:
*1 New user 4 link limit to post. Edited links in example code to workaround.
If there is a hotfix for this, or something I as an end user can do too disable this feature, delete the white-list code, it wouldn’t be an issue. I don’t see anyway of doing that. If there is, please someone tell me.
Doesn’t matter if it is a ‘temporary’ fix so websites that depend on facebook & twitter plug-in functions will work. I would sooner not visit or use the website in question. Or, just not be lied too.