Description of the issue:
Hi, I updated Brave to version 1.29.80 and I’ve noticed on the last two versions at least that when I download a file via Brave, it isn’t displaying the information properly for the download on the download bar.
Steps to Reproduce (add as many as necessary): 1. 2. 3.
Just download a file. I don’t have a Windows or Linux machine to test on.
Actual Result (gifs and screenshots are welcome!):
Expected result:
Displaying the information of the file downloaded, and the ‘Keep’ button.
Reproduces how often:
Always. I’ve only noticed this behaviour on the last two versions however I don’t download via Brave all the time as I tend to use JDownloader2.
Operating System and Brave Version(See the About Brave
page in the main menu):
Mac OSX Big Sur version 11.5 and 11.6.
Brave version 1.29.80
Additional Information:
This could be an issue specific to MacOS
as I can’t reproduce it on Windows 7.
Another report on MacOS
about the same issue:
→ "Keep" button do not show word "Keep" after download file
@Mattches might have to alert developers if you are able to reproduce the aforementioned issue.
@OrangeWaxKnight ,
I’m not able to reproduce this on my end. It does appear to be a graphical anomaly rather than a bug – I’m assuming that you can still select the Keep
option, is that correct?
Yes, both buttons work fine. I’ve tried changing the screen resolution to different scalings without any success. The website I’m going to is (https://karabiner-elements.pqrs.org/ ) and I’m downloading the DMG file there. Hope that helps.
1 Like
@OrangeWaxKnight ,
I’m actually wondering if it’s an HWA issue – can you try temporarily disabling Hardware Acceleration and test to see if the issue persists?
You’ll find this in Settings --> Additional Settings --> System --> Hardware Acceleration
Turned off hardware acceleration and downloaded the DMG file again. Download message still looks the same.
1 Like
@OrangeWaxKnight ,
Thank you for testing anyway – reaching out to the team to see if anyone else can reproduce this.
filSec
September 16, 2021, 2:35pm
8
@Mattches The same happens on my new Macbook Pro 16’’ even with Hardware Acceleration disable. Definitely a Brave Browser issue.
@filSec ,
Thank you for reporting.
I’ve opened the following issue for the developers to address:
opened 04:59PM - 16 Sep 21 UTC
OS/macOS
OS/Desktop
<!-- Have you searched for similar issues? Before submitting this issue, please … check the open issues and add a note before logging a new issue.
PLEASE USE THE TEMPLATE BELOW TO PROVIDE INFORMATION ABOUT THE ISSUE.
INSUFFICIENT INFO WILL GET THE ISSUE CLOSED. IT WILL ONLY BE REOPENED AFTER SUFFICIENT INFO IS PROVIDED-->
## Description
Downloading files from a potentially insecure source presents the option to `Keep` or `Discard` those files in the download bar. In some cases, the `Keep` option appears to display incorrect on the bar, although the button _does_ still function properly.
Note that this issue may be specific to macOS.
## Steps to Reproduce
1. Download a file/files from potentially insecure site
2. Options to `Keep` and/or `Discard`
3. Observe `Keep` displays incorrectly
## Actual result:

## Reproduces how often:
Intermittent
## Brave version (brave://version info)
v1.29.80
## Version/Channel Information:
- Can you reproduce this issue with the current release? Y
- Can you reproduce this issue with the beta channel? N/A
- Can you reproduce this issue with the nightly channel? N/A
## Miscellaneous Information:
Community threads reporting this issue:
https://community.brave.com/t/download-on-download-bar-information-isnt-displaying-correctly/282804?u=mattches
https://community.brave.com/t/download-on-download-bar-information-isnt-displaying-correctly/282804/8?u=mattches
2 Likes
Looks like we’ve pushed a fix for this already – thank you both for bringing it to our attention:
brave:master
← brave:bug/download-item-text-overlap
opened 08:53PM - 16 Aug 21 UTC
Resolves https://github.com/brave/brave-browser/issues/17313
The overlap was … caused by a recent change we made on the UX of the download item view.
The duped filename was setting itself visible in all modes. There are various modes to take in to consideration however, we only care about the normal mode.
This is what upstream is doing: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/views/download/download_item_view.cc;l=816;bpv=0;bpt=1
## Submitter Checklist:
- [x] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one
- [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [x] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [ ] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [ ] Checked the PR locally: `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests`, `npm run lint`, `npm run gn_check`, `npm run tslint`
- [ ] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
A detailed test plan is described in the issue.