feart
June 10, 2023, 12:39pm
1
Thread here requested (and got) MRU tab-switching using ctrl-tab. But it wasn’t implemented properly.
Ctrl-tab-tab places me on the second most recently used. So far so good.
But at that stage, the most recent tab has changed. MRU is the tab I was on when I ctrl-tab-tabbed. So when I ctrl-tab I expect it should go back to that, but instead ctrl-tab switches me to the tab I was on two ago.
Microsoft Windows’ alt-tab-tab is the model. Alt-tab doesn’t actually change the app. It gives a preview of the app that will be changed to. So Alt-tab-tab doesn’t actually change to the intermediate app en-route, it changes straight to the app MRU-but-one and updates the recent-used list. The app I was on when I alt-tab-tabbed becomes MRU, so alt-tabbing takes me straight back to it. Hence I can easily toggle between the two apps I want.
Brave doesn’t necessarily need to implement a “preview” of tabs in MRU order like Windows. When ctrl-tab-tabbing (or ctrl-tab-tab-tab, etc) Brave could simply not adjust MRU order until the ctrl key is unpressed. At that stage the tab I was on when I ctrl-tab-tabbed becomes MRU. This would fix.
Hope I’ve described this clearly. Essentially, it needs to work like MRU tab switching does in most other UIs\OSs. Brave isn’t truly MRU at the moment.
feart
June 10, 2023, 12:57pm
2
I see there’s are multiple github issues for this, two open, and one closed without fixing.
opened 06:37PM - 22 Sep 21 UTC
OS/Desktop
## Description
Pressing Ctrl+Tab doesn't support skipping to more than the dir… ectly single previous tab. Pressing it multiple times always goes back one tab. Very much not like Alt+Tab does in Windows or how Ctrl+Tab works everywhere else.
## Steps to Reproduce
1. Enable Ctrl+Tab MRU order in settings
2. Press and hold Ctrl key
3. Press Tab key multiple times
4. Release Ctrl key
5. Press Ctrl+Tab once again
## Actual result:
Tab active as before pressing Tab the last time in step 3
## Expected result:
Should move back to the tab that was active when pressing the Ctrl key in step 2
## Reproduces how often:
Easily reproduced
## Brave version (brave://version info)
<html>
<body>
Brave | 1.29.81 Chromium: 93.0.4577.82 (Offizieller Build) (64-Bit)
-- | --
Überarbeitung | e3a25d9b9e2d0b728e045ec87c0aa4942aa46e4e-refs/branch-heads/4577@{#1237}
Betriebssystem | Windows 10 OS Version 2009 (Build 19042.1237)
</body>
</html>
## Version/Channel Information:
- Can you reproduce this issue with the current release? yes
- Can you reproduce this issue with the beta channel? not installed
- Can you reproduce this issue with the nightly channel? not installed
## Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields? no
- Does the issue resolve itself when disabling Brave Rewards? no
- Is the issue reproducible on the latest version of Chrome? feature not available
opened 08:25PM - 25 Feb 21 UTC
bug
needs-investigation
feature/keyboard-shortcuts
priority/P4
QA/Yes
OS/Desktop
## Description
Reported in https://twitter.com/marknadal/status/13647300481592… 48384
> When "most recent ctrl+tab" mode
>
> Nothing happens upon tabbing after 1 new tab opened in background.
>
> If 2 open in background, then a switch does occur.
>
> Bug seems to skip switching to only 1st new background tab, but rest work.
## Steps to Reproduce
1.
2.
3.
## Actual result:
## Expected result:
## Reproduces how often:
## Brave version (brave://version info)
## Version/Channel Information:
- Can you reproduce this issue with the current release?
- Can you reproduce this issue with the beta channel?
- Can you reproduce this issue with the nightly channel?
opened 02:01PM - 15 Oct 20 UTC
closed 04:40PM - 22 Jan 21 UTC
closed/wontfix
closed/stale
## Description
I'm testing the feature introduced with
https://github.com/br… ave/brave-core/pull/4671
https://github.com/brave/brave-browser/issues/913
## Steps to Reproduce
1. Open 3 tabs. I will call them A, B and C from the left to the right
2. Click in sequence A, B, C just to reset the tab order
3. While on tab C, hold the Ctrl key, press Tab key 2 times and release Ctrl key. The selected tab should be tab A
4. Hold the Ctrl key and press tab key once
## Actual result:
The selected tab is now B
## Expected result:
The selected tab should be tab C.
If you look at how other browsers or applications using the Most Recently Used cycling work, they set the items order
when the Ctrl key is released and not when the Tab key is pressed.
This means that the tab B shouldn't be a recently viewed tab because the ctrl key wasn't released on it, but we only passed through during navigation.
I've recorded a video here (The first browser is Firefox, second is Brave nightly 1.18.8):
https://www.youtube.com/watch?v=WPKqNGYxzRs
## Reproduces how often:
Easily reproduced
## Brave version (brave://version info)
Brave | 1.17.32 Chromium: 86.0.4240.80 (Official Build) nightly (64-bit)
Revision | 7ed88b53bda45a2d19efb4f8706dd6b6cad0d3af-refs/branch-heads/4240@{#1183}
OS | Windows 10 OS Version 2004 (Build 19041.572)
## Version/Channel Information:
The functionality is not in stable channel yet
- Can you reproduce this issue with the current release?
N/A
- Can you reproduce this issue with the beta channel?
N/A
- Can you reproduce this issue with the nightly channel?
Yes
## Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields? No
- Does the issue resolve itself when disabling Brave Rewards? No
- Is the issue reproducible on the latest version of Chrome? N/A
## Miscellaneous Information:
Can’t hurt to have this thread too. Hope this can be implemented soon.