Saoiray:
Ok, sorry. Still sore from the past where you got mad at me as I shared things, especially if you had already commented in that topic thread. I was assuming you were going down that same path. I’ll try not to be so defensive if you ask similar in the future.
That was in a private DM and I think there were other issues involved that I do not care to discuss openly in the community forum.
Brave GitHub issue reports recently opened. No movement, but probably won’t be until after the weekend.
opened 12:25PM - 26 Jun 22 UTC
bug
feature/new-tab
priority/P4
OS/Desktop
## Description
Unable to use mouse to click on entry fields & save options whe… n adding (or editing) top sites. When use mouse to click on anything displayed, the dialogue box closes.
## Steps to Reproduce
1. Click Add (or Edit) Top Site
2. Use mouse to click a field or option in the dialogue box displayed
3. Dialogue box closes
## Actual result:
1. Can not enable data entry in a field using a mouse click because Dialogue box closes.
2. Can enter data in first field by just starting to type but need to use tab key to move to next field
3. Cannot click save button using mouse or dialogue box closes without saving.
4. To save data entered, do not use mouse click, just hit enter key on keyboard.
## Expected result:
Ability to use mouse clicks to move from field to field for data entry and save option.
## Reproduces how often:
Easily reproduced. Reproducible in Release, Beta, & Nightly.
## Brave version (brave://version info)
Release: 1.40.107 Chromium: 103.0.5060.53; Windows 10 Version 21H1 (Build 19043.1766)
Beta: 1.41.74 Chromium: 103.0.5060.53; same OS
Nightly: 1.42.29 Chromium: 103.0.5060.53; same OS
## Version/Channel Information:
- Can you reproduce this issue with the current release? Yes
- Can you reproduce this issue with the beta channel? Yes
- Can you reproduce this issue with the nightly channel? Yes
## Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields? Shields disabled by default on NTP
- Does the issue resolve itself when disabling Brave Rewards? N/A
- Is the issue reproducible on the latest version of Chrome? Unknown
## Miscellaneous Information:
Brave Community topics relating to issue report.
https://community.brave.com/t/cannot-add-new-favorite-top-site/406742
https://community.brave.com/t/i-cant-add-favorite-sites-on-my-new-tab/407069
https://community.brave.com/t/top-sites-bug-someone-knows-how-to-fix-it/407304
https://community.brave.com/t/i-cannot-manually-add-websites-to-the-the-top-sites-section-on-my-dashboard/407360
https://community.brave.com/t/unable-to-add-a-site-url-in-browsers-top-sites/407854
Unbelievable!To the developers: Is it possible to fix the function so that I can click with the mouse?
Thanks for this. It is indeed clunky, and I’m not at all certain why the original functionality no longer works. In my case, I was adding my “Google Calendar” and changed the name to be simply “Calendar”. One added point, as mentioned above, when editing the name, I found I was unable to save using the mouse. The dialog simply dismissed with no changes. So, more specifically, I had to tab over to the save button and hit enter.
Update: it appears on github that the issue is now closed and a browser update fixes the problem.
@dougp01 The cause is actually reported in a pull request at Brave GitHub. The fix is currently in Brave Nightly 1.42.x.
brave:master ← brave:fix-edit-site-dialog
opened 09:22PM - 27 Jun 22 UTC
Resolves https://github.com/brave/brave-browser/issues/23685, https://github.com… /brave/brave-browser/issues/23689
This fixes two issues with the add/edit site dialog:
1. The dialog would show under the grid sites.
2. The dialog would close when clicking on a field (because the click would be handled by the layer above it).
## Submitter Checklist:
- [x] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one
- [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [x] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [x] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [x] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [x] Checked the PR locally: `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests`, `npm run lint`, `npm run gn_check`, `npm run tslint`
- [x] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
Resolves brave/brave-browser#23685 , brave/brave-browser#23689
The dialog would show under the grid sites.
The dialog would close when clicking on a field (because the click would be handled by the layer above it).
Screen recording of Top Sites dialogue working with mouse clicks on Brave Nightly version 1.42.39. First time in years I’ve used a screen recording tool. Be kind.
Off-topic information below but compelled to share. lol
I used a screen recording program linked in the Useful Screenshot and Screen Recording tools to capture on-screen behavior topic in the Help Center and Resources/Community Resources category. Super easy to use! I have avoided using screen recordings in topics before because of past, and very painful, experiences with various screen recording tools. This was a breeze. Nice share by Brave support staff. Thank-you!
Screen Recording
LICEcap (Windows, macOS)
1 Like
I found a possible workaround to this issue.
system
July 30, 2022, 10:24am
30
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.
]