Bug: Brave Shields break Trezor Bridge/Connect when accessing wallet

Copy of Bug: Brave Shields break Trezor Bridge when accessing wallet because I am duplicating this issue as it remains unmitigated now on version 1.21.77 I have, in the meantime, been forced to use Brave with shields Ad blocking OFF (“Allow all trackers & ads”) and uBlock origin in place of this feature for the time being. I have verified the below-mentioned issues and initially noticed the problem on adalite-DOT-io - where this bug is easy to replicate.

Original (SEE LINK ABOVE FOR ORIGINAL LINKS, DUE TO SILLY NEW USER POLICY):

Admins: Please copy paste original text below if you can to retain linkage


Description of the issue: Brave Shields seem to cause Trezor Bridge to fail when accessing any variation of trezor-DOT-io (for instance, wallet-DOT-trezor-DOT-io will think the device isn’t connected). When using a Trezor hardware wallet to access external wallets, Brave Shields also prevent Trezor Bridge from working. I’ve tested this both on myetherwallet-DOT-com an adalite-DOT-io. Normally when you choose the hardware (Trezor) option, it redirects to connect-DOT-trezor-DOT-io and allows you to export the key and access the wallet.

However, if Brave Shields are enabled on either wallet-DOT-trezor-DOT-io (including connect-DOT-trezor-DOT-io or any variation), myetherwallet-DOT-com, or adalite-DOT-io, once you get redirected to the connect-DOT-trezor-DOT-io website you will get the error that Trezor bridge is not installed. When closing this window, MyEtherWallet displays the error message “Transport is unavailable.” AdaLite displays a message about disabling ad blockers. If shields are down for either of these sites, everything works normally.

Exact URL(s) of the website(s) in question: wallet-DOT-trezor-DOT-io, connect.trezor.io, myetherwallet.com, adalite.io

Did the issue present with default Shields settings? (yes/no) Yes

Does the site function as expected when Shields are turned off? Yes

Is there a specific Shields configuration that causes the site to break? If so, tell us that configuration. (yes/no): No

Does the site work as expected when using Chrome? Not tested.

Brave version (check About Brave ): Version 1.19.88 Chromium: 88.0.4324.96 (Official Build) (x86_64) → 1.21.77


Mentioning original submitter @lavt91

@xenithorb,
Thank you for resubmitting this. Reaching out to the team now. Can you also tell me what OS you’re using?

Hey, which shield options is causing it? Does disabling Ads/trackers help?

Hi!

I’m using Fedora 33, kernel 5.10.21-200.fc33.x86_64

Version 1.21.77 Chromium: 89.0.4389.90 (Official Build) (64-bit)
](https://brave.com/latest/)

Hi @fanboynz,

This MUST be disabled for it to work, I typically keep it on Aggressive and also tried Standard, with no success.

However, Disabling that setting exactly, and using uBlock instead works.

Some more information:

^ This is what occurs on the client side when you click the pink “Unlock with Trezor” button AND the above-mentioned Shield setting is ENABLED either standard or aggressive

Is this screenshot coming from https://trezor.io/ ? @xenithorb

As a test, try adding @@||127.0.0.1^$domain=trezor.io into brave://adblock

2 Likes

The screenshot is on adalite.io, but the filter rule you proposed does in fact work!

I verified on a fresh Brave Beta profile this filter rule restores the ability of sites like ADAlite.io to connect to the connect.trezor.io client, outstanding.

Is there a way to propose this gets added to the default ruleset?

Sure, just want to reach out to Trezor first. https://twitter.com/fanboynz/status/1372795388306935811?s=20

Okay Landing https://github.com/brave/adblock-lists/pull/583

Give it 24-48hrs. Though no response from Trezor.