Cored
September 2, 2021, 3:45am
#1
Description of the issue:
Steps to Reproduce (add as many as necessary): 1. 2. 3.
Actual Result (gifs and screenshots are welcome!):
Expected result:
Reproduces how often:
Operating System and Brave Version(See the About Brave page in the main menu):
Additional Information:
Yes, it’s a new addition since the latest release.
brave:master ← brave:crash_report_permission_ask_dialog
opened 01:08PM - 21 Jul 21 UTC
Launch crash reporting permission ask dialog on startup after crash.
Launch tab… restore dialog after permission ask dialog is closed.
By overriding, ShowIfNotOffTheRecordProfileBrave() is called instead of
ShowIfNotOffTheRecordProfile().
ShowIfNotOffTheRecordProfileBrave() will launch crash reporting permission
ask dialog and then tab restore dialog is launched after permission ask dialog
is closed.
<img width="449" alt="Screen Shot 2021-07-27 at 9 56 19 PM" src="https://user-images.githubusercontent.com/6786187/127157366-d3d2eb11-3b7b-41a9-bcb5-b57e6165c817.png">
<img width="449" alt="Screen Shot 2021-07-27 at 9 56 38 PM" src="https://user-images.githubusercontent.com/6786187/127157376-9badbdf8-ab52-4625-8ef0-9def1e609bae.png">
Resolves https://github.com/brave/brave-browser/issues/1841
## Submitter Checklist:
- [x] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one
- [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [x] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [x] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [x] Checked the PR locally: `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests`, `npm run lint`, `npm run gn_check`, `npm run tslint`
- [x] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
`npm run test brave_unit_tests -- --filter=MetricsUtilTest*`
`npm run test brave_browser_tests -- --filter=CrashReportPermissionAskDialogTest*`
1. Launch browser and open several tabs
2. Check crash report is not enabled from brave://settings/privacy
3. Load brave://inducebrowsercrashforrealz to simulate browser crash
4. Check crash reporting permission ask dialog is launched
4-1. Click Block and check tab restore bubble is displayed
4-2. Click Allow and check tab restore bubble is displayed
4-2-1. Check crash reporting is enabled from brave://settings/privacy
The only way to block the displaying of the dialog as of the moment is clicking on Allow. Brave will continue sending crash reports silently but you won’t see the dialog again. I think developers made a mistake by not allowing users to block the dialog by clicking on Block, hopefully they’ll change that in future updates.
P.S Got developers’ attention:
opened 12:00AM - 31 Aug 21 UTC
OS/Desktop
I am running Version 1.29.71 Chromium: 92.0.4515.159 (Official Build) beta (64-b… it)
and Version 1.31.7 Chromium: 93.0.4577.58 (Official Build) nightly (64-bit)
**This appears to affect only Beta and Nightly users and most likely other users that are not using stable**
This dialogue box never even appeared for me until a couple weeks ago (probably introduced in an update).
Steps to reproduce:
1. Make sure the browser has "Help improve Brave's features and performance" toggled off in settings, restart if necessary.
2. Crash the browser in an "unexpected" way "brave://inducebrowsercrashforrealz"
3. Relaunch the browser
4. You should now see the menu popup. This keeps happening every time until you opt-in to crash reports.
Expected result:
Once the user clicks "block", the dialogue box should never appear again unless the user has turned on crash reporting and then off again, resetting the cycle, or just never showing the dialogue box ever again after the user clicks "block".
Normally I would see this box and I would like to keep it that way. Especially when I opt-out to crash reports, since it's mostly my computer crashing and not the browser itself.
Closing words:
Brave Browser is a Chromium browser that boasts security, and respecting user privacy. If this is the case, then respect us when we click "block" after asking us to opt-in to crash reports, and never ask again.
system
October 2, 2021, 4:05am
#3
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.