mbolz
March 30, 2023, 5:34pm
1
Brave Version v1.49.132
I have several assets in my wallet, and they all seem to be displaying correctly except for one: “Chrono.Tech TIME” on the Ethereum network for which the balance seems to keep refreshing forever, never actually displaying. The wallet also does not respond to my clicking on that asset.
@mbolz Hello, I have this issue too. I reported this issue and another display issue in a Brave Support ticket. The response was that the fix will be released in version 1.50.x. But when I look at the issue report, the continuous refresh problem doesn’t seem to apply.
brave:master
← brave:use-contract-address-in-spot-prices
opened 09:08PM - 24 Feb 23 UTC
## Description
Fixes a bug where If you add the same token for a L1 network an… d L2 network, if the token on the L1 network doesn't have a balance, the fiat value would show 0.00 for the token on the L2 network with a balance.
Resolves <https://github.com/brave/brave-browser/issues/28753>
## Submitter Checklist:
- [x] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one
- [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [x] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [x] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [x] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [x] Checked the PR locally:
* `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests` [wiki](https://github.com/brave/brave-browser/wiki/Tests)
* `npm run lint`, `npm run presubmit` [wiki](https://github.com/brave/brave-browser/wiki/Presubmit-checks), `npm run gn_check`, `npm run tslint`
- [ ] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
1. Add a token that has a balance on a L2 chain
2. Now add that same token on a `L1` chain without a balance
3. The L2 fiat balance should not show 0.00
Before:
https://user-images.githubusercontent.com/40611140/221292381-3c1d83f6-5b30-4c46-acfc-63dd2f06527a.mov
After:
https://user-images.githubusercontent.com/40611140/221292411-229d1316-f1ad-4d8b-a2bb-bb97641191b2.mov
Tagging @Evan123 @hub
Can you confirm this fix is for both fiat display issues (e.g. token amt displays but not $ amount) and for issues where the fiat amount never displays (just get a continuous refresh circle)?
mbolz
March 30, 2023, 10:11pm
3
I don’t actually see the refresh circle displaying. Rather on the main portfolio screen in the column on the right side of the page, the location where the fiat value, and the token balance are supposed to be… It simply displays those fields as 2 bars where the numbers are supposed to be displayed. And those two bars have a gray area continuously travelling from left to right.
1 Like
Same here, but when I hover over the lines, I still see the lines but also a blue circle going round and round continuously! “Refresh circle” probably isn’t the right terminology but didn’t know what else to call it! lol
mbolz
March 30, 2023, 11:40pm
5
When I hover the cursor over the lines nothing changes, except that my mouse cursor becomes an hourglass. I do not see the “waiting circle”.
mbolz
April 7, 2023, 3:52pm
7
I do not see any label “custom assets”
mbolz
April 7, 2023, 3:55pm
8
I do not see anything labeled “custom assets” to click on?
mbolz
April 7, 2023, 4:45pm
10
That made the situation worse. Now it displays a balance, but the problem is it displays a zero balance, which is also incorrect.
mbolz
April 11, 2023, 7:33pm
12
I am sorry, but I don’t know how to do this, and I also don’t know when the original transaction placed the TIME into my wallet.
system
Closed
May 12, 2023, 10:50pm
14
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.