Brave Crashes When Website Opens a Pop-up in Private Tabs With Tor


#1

Description of the issue: The Brave Browser crashes whenever a pop-up loads. The pop-up windows flashes black for a split second and then the browser crashes to desktop. Shields active: Show brave ads, Block 3rd party cookies, block all fingerprinting, block phishing/malware, HTTPS everywhere.

Steps to Reproduce (add as many as necessary):

  1. Open Brave
  2. Use the hamburger menu to open a private tab with tor
  3. Navigate to a website with known pop-ups
  4. Navigate to a specific page you know has an ad pop-up
  5. Pop-up triggered, browser crashes

Actual Result (gifs and screenshots are welcome!): Brave Browser crashes immediately after pop-up triggered. Pop-up window is black for a split second before crash.

Expected result: Not allow pop-ups at all, or at least not crash and allow the user to close it themselves.

Reproduces how often: Always

Brave Version(about:brave):
Brave: 0.23.31
V8: 6.7.288.46
rev: 3148acef36dba0fce89108638bb27927c4937f90
Muon: 7.1.5
OS Release: 10.0.17134
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Tor: 0.3.3.7 (git-035a35178c92da94)
Brave Sync: v1.4.2
libchromiumcontent: 67.0.3396.103

Reproducible on current live release (yes/no): Yes


#2

Does this happen on all sites which shows popup windows or any specific site? Does the same site cause crash on normal tabs/private tabs as well? Is it consistently reproducing for a specific site. if so could you share the site link for which it happens?

Could you try launching the browser from Git bash window and capture logs ? You can download Git bash from here. You can launch browser using %appdata%\local\brave\brave.exe in git bash window


#3

Hi @sriram I almost created a separate Github issue regarding a similar bug figured I’d just respond here if it’s alright.

I noticed the same issue. I was trying to get into a direct conversation with the Brave community via Discord and every single time I go to validate the new Discord account in ProtonMail, it terminates the browser.

Reproducible 100%.

UPDATE: I was also curious @sriram wouldn’t it be best to include this under the ‘private-tabs-with-tor’ label/category. :slight_smile:

Brave: 0.23.31 
V8: 6.7.288.46 
rev: 3148acef36dba0fce89108638bb27927c4937f90 
Muon: 7.1.5 
OS Release: 4.12.14-lp150.12.4-default 
Update Channel: Release 
OS Architecture: x64 
OS Platform: Linux 
Node.js: 7.9.0 
Tor: 0.3.3.7 (git-035a35178c92da94) 
Brave Sync: v1.4.2 
libchromiumcontent: 67.0.3396.103

#4

@Numpty does it crash on when opening any links via mail? Any console logs after crash?


#5

The console log is empty and the crash basically occurs when you click on any external link within an email.