Brave crashes upon JavaScript popup in Google Tasks


#1

Platform is macOS. Works on Chrome but not Brave. Crash seems to be 100% reproducible. Just upgraded to Brave 0.20.29 version.

  1. Open Google Tasks: https://mail.google.com/tasks/canvas
  2. Task lists displayed in left column, click dropdown, click Rename List menu item
  3. JavaScript dialog box should pop up, but instead, Brave crashes

Anybody else notice this?

Josh


#2

Do you mind telling what shields settings you are using? Also do you have Site isolation enabled? If so please disable and check it and let know if it works.


#3

Not sure what Site Isolation is. What’s that setting?

As for Shields (the lion icon at upper right corner), I tested it both with and without.

It still crashed, both times. Interestingly, it spins the pinwheel for about 10 seconds, then crashes. The crash isn’t instant. However, with Shields down, the crash happened faster, about 5 seconds, instead of 10.

Here’s part of the dump. Maybe this will help?

Process:               Brave [95009]
Path:                  /Applications/Brave.app/Contents/MacOS/Brave
Identifier:            com.electron.brave
Version:               0.20.29 (4.7.9)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           Brave [95009]
User ID:               501

Date/Time:             2018-02-01 14:04:03.583 -0800
OS Version:            Mac OS X 10.13.3 (17D47)
Report Version:        12

System Integrity Protection: enabled

Crashed Thread:        0  CrBrowserMain  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000008

VM Regions Near 0x8:
--> 
    __TEXT                 000000010c008000-000000010c009000 [    4K] r-x/rwx SM=COW  /Applications/Brave.app/Contents/MacOS/Brave

Thread 0 Crashed:: CrBrowserMain  Dispatch queue: com.apple.main-thread
0   org.brave.Brave.framework     	0x000000010d605e05 0x10c056000 + 22740485
1   org.brave.Brave.framework     	0x000000010d44422b 0x10c056000 + 20898347
2   org.brave.Brave.framework     	0x000000010d1afd5f 0x10c056000 + 18193759
3   org.brave.Brave.framework     	0x000000010d1afa8e 0x10c056000 + 18193038
4   org.brave.Brave.framework     	0x000000010d1abce8 0x10c056000 + 18177256
5   org.brave.Brave.framework     	0x000000010da91b9b 0x10c056000 + 27507611
6   org.brave.Brave.framework     	0x000000010d9de57c 0x10c056000 + 26772860
7   org.brave.Brave.framework     	0x000000010da00224 0x10c056000 + 26911268
8   org.brave.Brave.framework     	0x000000010da00739 0x10c056000 + 26912569
9   org.brave.Brave.framework     	0x000000010da0255a 0x10c056000 + 26920282
10  org.brave.Brave.framework     	0x000000010d9f4c7a 0x10c056000 + 26864762
11  org.brave.Brave.framework     	0x000000010da01e7f 0x10c056000 + 26918527
12  com.apple.CoreFoundation      	0x00007fff53a34721 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
13  com.apple.CoreFoundation      	0x00007fff53aee0ac __CFRunLoopDoSource0 + 108
14  com.apple.CoreFoundation      	0x00007fff53a17260 __CFRunLoopDoSources0 + 208
15  com.apple.CoreFoundation      	0x00007fff53a166dd __CFRunLoopRun + 1293
16  com.apple.CoreFoundation      	0x00007fff53a15f43 CFRunLoopRunSpecific + 483
17  com.apple.HIToolbox           	0x00007fff52d2de26 RunCurrentEventLoopInMode + 286
18  com.apple.HIToolbox           	0x00007fff52d2db96 ReceiveNextEventCommon + 613
19  com.apple.HIToolbox           	0x00007fff52d2d914 _BlockUntilNextEventMatchingListInModeWithFilter + 64
20  com.apple.AppKit              	0x00007fff50ff8f5f _DPSNextEvent + 2085
21  com.apple.AppKit              	0x00007fff5178eb4c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044
22  com.apple.AppKit              	0x00007fff50fedd6d -[NSApplication run] + 764
23  org.brave.Brave.framework     	0x000000010da02e17 0x10c056000 + 26922519
24  org.brave.Brave.framework     	0x000000010da0199e 0x10c056000 + 26917278
25  org.brave.Brave.framework     	0x000000010da1e1b4 0x10c056000 + 27034036
26  org.brave.Brave.framework     	0x000000010d078370 0x10c056000 + 16917360
27  org.brave.Brave.framework     	0x000000010d0781a0 0x10c056000 + 16916896
28  org.brave.Brave.framework     	0x000000010d07ab02 0x10c056000 + 16927490
29  org.brave.Brave.framework     	0x000000010d07477c 0x10c056000 + 16902012
30  org.brave.Brave.framework     	0x000000010d9d666f 0x10c056000 + 26740335
31  org.brave.Brave.framework     	0x000000010edf158b 0x10c056000 + 47822219
32  org.brave.Brave.framework     	0x000000010d9d5c24 0x10c056000 + 26737700
33  org.brave.Brave.framework     	0x000000010c058b54 ChromeMain + 724
34  com.electron.brave            	0x000000010c008dba main + 522
35  libdyld.dylib                 	0x00007fff7b32d115 start + 1

#4

Same applies to me, I was using Teamtreehouse website today to learn JavaScript and when ever I ran an execution that involved the alert dialog, Brave would close itself. Just like you, turning off shields didn’t make a difference.


#5

I have a similar problem. Tracing the javascript for the page I was on showed that Brave will crash on a call to window.prompt(). I’m on Windows 10 Pro 64-bit.


#6

Sorry for the delayed response. We have an issue logged for this and can be tracked here

Its an issue with javascript prompt not being handled. Console throws the following error causing crash
image

Closing the thread for now. Please subscribe to the github thread or bookmark it to see the progress.


#7