Brave adblock doesn't trigger ^$all filter

Description of the issue:
Hello brave dev, It seems like brave Adblock doesn’t support ^$all in Ublock-Badware Risks. I found a scam crypto site, it blocked in uBO but this site is not blocked in brave. I wish brave developers will fix it because badware risks filter very important to protect brave users from scam and malware sites

Exact URL of the website in question:
give-crypto.com

Screenshot of the ad as it appears in Brave
**Did the issue present with default Shields settings?**YES

**Does the site function as expected when Shields are turned off?**NO

**Is there a specific Shields configuration that causes the site to break? If so, tell us that configuration. (yes/no):**NO

**Does the site work as expected when using Chrome?**NO

**Brave version (check About Brave):**1.45.123

Brave has never supported $all, so that’s why.

The all option is equivalent to specifying all network-based types + popup , document , inline-font and inline-script .

Brave doesn’t support popup, inline-font or inline-script, that’s why

Also, to block a site you use either ||domain.example^ to block everything, get warning screen and apply every network filter on it, or I guess you can use ||domain.example^$document if you want only get the warning screen but don’t block anything else than that, so you can still ‘proceed’ and get the site displaying correctly.
Of course, the first one is the common one.

So, brave only support domain ^ in uBO badware risks filter :thinking:

Yeah, all those $all and the procedural cosmetics are currently ignored.

So the urlhaus filter for Adguard that is inserted into brave Adblock is also useless because it doesn’t work

https://malware-filter.gitlab.io/malware-filter/urlhaus-filter-ag-online.txt

Yes and the problem is, 28 days ago was when they merged and switched from this to the “light” version which includes $all all over the place instead of just ^ (for whatever reason), it was done because of memory reasons but now it will be less useful for sure.
This is why I load them as Custom lists, less trouble for sure! even if some features, like apparently $badfilter only works for default lists and not for others because they need to merge adblock engines to make things work better. But I don’t care, the only time I noticed the issue was when clicking links in twitter, so I get the warning blocked message/proceed message. And the other downside is how custom lists have to be manually updated until they support the features like Expires: to update lists more often rather than 7 days.

Can you open pull request on github? I think they should replace urlhaus with this one. This is light version https://malware-filter.gitlab.io/malware-filter/urlhaus-filter-agh-online.txt

Done. They will change it to use the light version you are mentioning.

1 Like