Bookmark Manager module

Contributing Developers
1

Hello there,

I’m new to the project. This morning I discovered a bug in the Bookmark Manager module and decided to try to fix it.

While I was going through the js/about/bookmarks.js module, I noticed that we are creating many classes inside this file, and it’s now > 500 lines. Is there a reason we cannot separate BookmarkFolderItem, BookmarkFolderList, BookmarkTitleHeader, etc. into separate files and import them into the main AboutBookmarks component? I think each component would look beautifully simple in isolation.

I would love to hear your thoughts.

Cheers!

1 Like
2

Hi,

I completely agree with you, about pages we still have a lot of legacy code. We are slowly converting things into separate files (like this PR for example https://github.com/brave/browser-laptop/pull/9694). So if you see places where we can split things, we would much appreciate your help with it.

If you need any help or guidance, let me know and I will happily help you out.

1 Like