teobb
March 6, 2021, 2:20pm
1
It could improve a lot the use of the new page, there is a lot of room, user could have the choice in settings of number of tiles (number of rows composed of 6 tiles)
I agree. There should be more Top Sites tiles. I always rather use the big and easy-to-click tiles than fumbling through my bookmarks. There should be more customizability in this area. Different size tiles to fill the New Tab screen with variety would be nice as well.
2 Likes
FClark
March 16, 2022, 10:16pm
3
I would prefer an even four rows of eight columns (36) like Mozzilla allows. 10 tiles is just not enough. At least Mozzilla allows you to have choices of number of rows and columns. otherwise, I’m gone.
2 Likes
Too many rows would make the ads image less visible.
Just to clarify, as far as Frequently visited sites go, these are limited to six, yes. However if you want to have more tiles here, you can set custom sites here as “top-sites” which allows for up to 12 tiles:
I’m not particular about the number or arrangement, but I voted yes for more tiles.
Also it would be nice to allow a tile be a folder (open all on clicking).
The dashboard is a very important page for Brave users; I prefer to see this.
For stats page: small stats line as this will give room for more sites icons and the space for the sponsor is not compromised.
NB. In the begining of each month, the note about the date of the payout makes the features at bottom right almost invisible.
For news: 3 headlines per line is best. It’s quicker to scroll and no need for big images headlines because at the end you have to click on them to see the news details.
2 Likes
Ya I’m going to need MANY more tiles than 12, try unlimited. Not only that, I want to be able to group them. Personally I really LOVE how Opera has done that and until Brave will allow more tiles, I am not ready to switch.
1 Like
Live in Nightly 1.43.x. Top sites pagination implemented. 12 top sites per “page”. I created two pages (24 sites) and had another page available. Worked fine. Do not know if there is a max and wasn’t going to test more. lol Cannot add duplicate url so that is great (although others may disagree)! Can drag icons between pages to rearrange icons (a little cumbersome to me but worked). Several related Brave GitHub issue reports linked below.
opened 08:25AM - 26 Oct 19 UTC
closed 09:00PM - 11 Jul 22 UTC
feature/new-tab
priority/P3
QA/Yes
release-notes/include
feature-request
OS/Desktop
<!-- Have you searched for similar issues? Before submitting this issue, please … check the open issues and add a note before logging a new issue.
PLEASE USE THE TEMPLATE BELOW TO PROVIDE INFORMATION ABOUT THE ISSUE.
INSUFFICIENT INFO WILL GET THE ISSUE CLOSED. IT WILL ONLY BE REOPENED AFTER SUFFICIENT INFO IS PROVIDED-->
## Description
Block space for frequently visited sites (div class="sc-bbmXgH fIpoOp"> ) if made to adapt responsively and expand to full width depending on how many sites users might want to see there.
## Brave version (brave://version info)
Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.14.6 (Build 18G95)
JavaScript V8 7.8.279.17
Flash (Disabled)
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.70 Safari/537.36
Command Line /Applications/Brave Browser.app/Contents/MacOS/Brave Browser --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --sync-url=https://no-thanks.invalid --enable-features=NewExtensionUpdaterService,PasswordImport,WebUIDarkMode,SimplifyHttpsIndicator --disable-features=AutofillServerCommunication,LookalikeUrlNavigationSuggestionsUI,NotificationTriggers,AudioServiceOutOfProcess,SmsReceiver,SyncUSSBookmarks,UnifiedConsent --flag-switches-begin --flag-switches-end
Executable Path /Applications/Brave Browser.app/Contents/MacOS/Brave Browser
Profile Path /Users/chetanpm/Library/Application Support/BraveSoftware/Brave-Browser/Default
## Miscellaneous Information:
brave:master
← brave:ntp-pagination
opened 12:44AM - 08 Jun 22 UTC
Resolves [#6619](https://github.com/brave/brave-browser/issues/6619)
## Submi… tter Checklist:
- [x] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one
- [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [ ] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [ ] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [ ] Checked the PR locally: `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests`, `npm run lint`, `npm run gn_check`, `npm run tslint`
- [ ] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [x] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [x] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
opened 11:06PM - 14 Jul 22 UTC
feature/new-tab
priority/P3
QA/Yes
release-notes/exclude
OS/Desktop
<!-- Have you searched for similar issues? Before submitting this issue, please … check the open issues and add a note before logging a new issue.
PLEASE USE THE TEMPLATE BELOW TO PROVIDE INFORMATION ABOUT THE ISSUE.
INSUFFICIENT INFO WILL GET THE ISSUE CLOSED. IT WILL ONLY BE REOPENED AFTER SUFFICIENT INFO IS PROVIDED-->
## Description
As a follow-up to top sites pagination https://github.com/brave/brave-browser/issues/6619 :
1. Remove the 1 "dot"/page enumeration until user creates a second page (or more than 6 top sites). Looks like a floating dot with only six tiles.
2. With Brave News on, selecting the second "page" or second set of top sites makes Brave News peek up even more.
3. When selecting a page 1, 2, 3, or 4 in top sites, opening a new tab page should keep you on the page you selected. For example, select page 3 on the existing new tab page. Open a new tab page, and top sites should remain on page 3. If a user has multiple new tab pages open, a change in one should not reflect in the others. Only a new tab should reflect the last selected pagination state.
## Steps to Reproduce
See above. Using 1.43.20 and higher. To reproduce 1, need only 6 top sites. To reproduce 2 and 3 requires 12 to 36 top sites. Can pick sites from here `https://www.visualcapitalist.com/the-50-most-visited-websites-in-the-world/` or choice websites.
## Actual result:
<img width="573" alt="Screenshot 2022-07-14 at 4 08 11 PM" src="https://user-images.githubusercontent.com/5951041/179116333-d03b735c-67ff-4e0c-8357-28fd701acde1.png">
<img width="1198" alt="screenshot_2022-07-14_at_10 28 17_am" src="https://user-images.githubusercontent.com/5951041/179116128-53770058-7ee2-4433-bc45-2cfdc9de1d58.png">
1. Dot shown on one page.
2. Brave News peeks higher with selection of page 2.
3. Opening a new tab page always shows the first set of tiles or first page versus last viewed.
## Expected result:
1. No dot with first page/first set of six sites.
2. No movement with Brave News with selection of pagination with top sites.
3. Show last viewed page on opening of a new tab page.
## Reproduces how often:
Easily.
## Brave version (brave://version info)
1.43.20 and higer
## Version/Channel Information:
- Can you reproduce this issue with the current release? no
- Can you reproduce this issue with the beta channel? no
- Can you reproduce this issue with the nightly channel? yes
## Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields? n/a
- Does the issue resolve itself when disabling Brave Rewards? n/a
- Is the issue reproducible on the latest version of Chrome? n/a
## Miscellaneous Information:
brave:master
← brave:ntp-cleanup
opened 10:23PM - 14 Jul 22 UTC
Resolves https://github.com/brave/brave-browser/issues/24071
This PR makes th… e following quality of life improvements to NTP Pagination:
1. Don't show the page buttons unless there are multiple pages.
2. Don't trigger the Brave News peek when clicking a page change button.
3. When opening a NTP, show the last viewed page, rather than the first page.
## Submitter Checklist:
- [x] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one
- [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [x] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [x] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [x] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [ ] Checked the PR locally: `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests`, `npm run lint`, `npm run gn_check`, `npm run tslint`
- [ ] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [x] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [x] New files have MPL-2.0 license header
- [x] Adequate test coverage exists to prevent regressions
- [x] Major classes, functions and non-trivial code blocks are well-commented
- [x] Changes in component dependencies are properly reflected in `gn`
- [x] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [x] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
See the linked issue
Brave Release version 1.43.x scheduled for Aug 30.
4 rows instead 2 - 3 rows, with 8 icons per row, same as Firefox please.
The multiple rows would be a great addition. If nothing else please make the way to change the favorite sites button bigger. It’s annoying trying to click this small button. Very unnecessary IMO.
Moris91
February 19, 2024, 1:10am
12
I came here from FireFox where I have 32 tabs
Why such limt?
Saoiray
February 19, 2024, 1:19am
13
Moris91:
Why such limt?
I’m sure they have a lot of excuses and all, but primary one is just that they want to leave space for NTP ads. If they allow us to have a crapload of top sites there, then it would flood out any of the advertisements behind it. Definitely wouldn’t be a good thing when it comes to ad sales.
Besides, no real rhyme or reason for us to have that anyway. If you need all your bookmarks or top sites, just make that your home page. Or otherwise just use your bookmarks bar and/or sidebar to access it.