Description of the issue:
Using the pre-release version 1.26.63 I crash when I click on “Brave Shields & Privacy” in the settings page. The app doesn’t close itself, but the settings page closes itself. If I do try again I get a popup about the browser not responding.
How can this issue be reproduced?
Install the latest pre-release version for android from https://github.com/brave/brave-browser/releases/tag/v1.26.63
Once installed navigate into Settings > Press on “Brave Shields & Privacy”.
Observe what happens.
Expected result:
I expect to get taken to whatever page that the setting option takes me to. Or if there is an error due to some setting I may have enabled, to be greeted with an error message.
Brave Version( check About Brave
):
Version: 1.26.63
Mobile Device details
Xiaomi Redmi Note 7
Rooted
Using LineageOS 18.1
Security Update: June 2021
Additional Information:
None that I can think of
The pull-request below supposedly fixes the issue:
brave:master
← brave:fix_fingerprinting_option_android
opened 10:40PM - 18 Jun 21 UTC
Resolves https://github.com/brave/brave-browser/issues/16510
## Submitter Che… cklist:
- [ x] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one
- [ x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [ x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [ ] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [ ] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [ ] Checked the PR locally: `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests`, `npm run lint`, `npm run gn_check`, `npm run tslint`
- [ ] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
Awesome. Thanks. Should be brought into stable soon
system
Closed
July 19, 2021, 5:24pm
4
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.